View | Details | Raw Unified | Return to bug 20256
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Patrons.t (-2 / +76 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 42;
22
use Test::More tests => 43;
23
use Test::Warn;
23
use Test::Warn;
24
use Test::Exception;
24
use Test::Exception;
25
use Test::MockModule;
25
use Test::MockModule;
Lines 2180-2183 subtest 'queue_notice' => sub { Link Here
2180
    is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter,"Count of queued notices not increased in test mode");
2180
    is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter,"Count of queued notices not increased in test mode");
2181
};
2181
};
2182
2182
2183
subtest 'libraries_where_can_edit_items + can_edit_item' => sub {
2184
    plan tests => 2;
2185
2186
    $schema->storage->txn_begin;
2187
    my $dbh = $schema->storage->dbh;
2188
2189
    $dbh->do("DELETE FROM library_groups");
2190
2191
    # group1
2192
    #   library_1A
2193
    #   library_1B
2194
    # group2
2195
    #   library_2A
2196
    my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_limit_item_editing => 1 } )->store;
2197
    my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_limit_item_editing => 1 } )->store;
2198
    my $library_1A = $builder->build( { source => 'Branch' } );
2199
    my $library_1B = $builder->build( { source => 'Branch' } );
2200
    my $library_2A = $builder->build( { source => 'Branch' } );
2201
    $library_1A = Koha::Libraries->find( $library_1A->{branchcode} );
2202
    $library_1B = Koha::Libraries->find( $library_1B->{branchcode} );
2203
    $library_2A = Koha::Libraries->find( $library_2A->{branchcode} );
2204
    Koha::Library::Group->new( { branchcode => $library_1A->branchcode, parent_id => $group_1->id } )->store;
2205
    Koha::Library::Group->new( { branchcode => $library_1B->branchcode, parent_id => $group_1->id } )->store;
2206
    Koha::Library::Group->new( { branchcode => $library_2A->branchcode, parent_id => $group_2->id } )->store;
2207
2208
    my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 9, ?)|); # 9 for editcatalogue
2209
    # 2 patrons from library_1A (group1)
2210
    # patron_1A_1 see patron's infos from outside its group
2211
    # Setting flags => undef to not be considered as superlibrarian
2212
    my $patron_1A_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2213
    $patron_1A_1 = Koha::Patrons->find( $patron_1A_1->{borrowernumber} );
2214
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_items' );
2215
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_any_item' );
2216
    # patron_1A_2 can only see patron's info from its group
2217
    my $patron_1A_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2218
    $patron_1A_2 = Koha::Patrons->find( $patron_1A_2->{borrowernumber} );
2219
    $sth->execute( $patron_1A_2->borrowernumber, 'edit_items' );
2220
    # 1 patron from library_1B (group1)
2221
    my $patron_1B = $builder->build({ source => 'Borrower', value => { branchcode => $library_1B->branchcode, flags => undef, }});
2222
    $patron_1B = Koha::Patrons->find( $patron_1B->{borrowernumber} );
2223
    # 1 patron from library_2A (group2) can only see patron's info from its group
2224
    my $patron_2A = $builder->build({ source => 'Borrower', value => { branchcode => $library_2A->branchcode, flags => undef, }});
2225
    $patron_2A = Koha::Patrons->find( $patron_2A->{borrowernumber} );
2226
    $sth->execute( $patron_2A->borrowernumber, 'edit_items' );
2227
2228
    subtest 'libraries_where_can_edit_items' => sub {
2229
        plan tests => 3;
2230
2231
        my @branchcodes;
2232
2233
        @branchcodes = $patron_1A_1->libraries_where_can_edit_items;
2234
        is_deeply( \@branchcodes, [], "patron_1A_1 has edit_any_item => No restrictions" );
2235
2236
        @branchcodes = $patron_1A_2->libraries_where_can_edit_items;
2237
        is_deeply( \@branchcodes, [ sort ( $library_1A->branchcode, $library_1B->branchcode ) ], "patron_1A_2 doesn't have edit_any_item => Can only edit items from its group" );
2238
2239
        @branchcodes = $patron_2A->libraries_where_can_edit_items;
2240
        is_deeply( \@branchcodes, [$library_2A->branchcode], "patron_2A doesn't have edit_any_item => Can only see patron's from its group" );
2241
    };
2242
2243
    subtest 'can_edit_item' => sub {
2244
        plan tests => 6;
2245
2246
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_1 });
2247
        is( $patron_1A_1->can_edit_item( $library_1A->id ), 1, "patron_1A_1 can see patron_1A_2, from its library" );
2248
        is( $patron_1A_1->can_edit_item( $library_1B->id ),   1, "patron_1A_1 can see patron_1B, from its group" );
2249
        is( $patron_1A_1->can_edit_item( $library_2A->id ),   1, "patron_1A_1 can see patron_1A_2, from another group" );
2250
2251
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_2 });
2252
        is( $patron_1A_2->can_edit_item( $library_1A->id ),   1, "patron_1A_2 can see patron_1A_1, from its library" );
2253
        is( $patron_1A_2->can_edit_item( $library_1B->id ),   1, "patron_1A_2 can see patron_1B, from its group" );
2254
        is( $patron_1A_2->can_edit_item( $library_2A->id ),   0, "patron_1A_2 can NOT see patron_2A, from another group" );
2255
    };
2256
};
2257
2183
$schema->storage->txn_rollback;
2258
$schema->storage->txn_rollback;
2184
- 

Return to bug 20256