Bugzilla – Attachment 121852 Details for
Bug 28489
CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28489: Don't deal with encoding during the serialization
Bug-28489-Dont-deal-with-encoding-during-the-seria.patch (text/plain), 1.22 KB, created by
Jonathan Druart
on 2021-06-11 14:05:28 UTC
(
hide
)
Description:
Bug 28489: Don't deal with encoding during the serialization
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-11 14:05:28 UTC
Size:
1.22 KB
patch
obsolete
>From 32c979b2cf88910a3e2b098286afe1f7a47ded91 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 5 Jun 2021 15:27:02 +0200 >Subject: [PATCH] Bug 28489: Don't deal with encoding during the serialization > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Auth.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index cf254ba60ef..cb35984b2ef 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -9,19 +9,18 @@ $INC{'CGI/Session/Serialize/yamlxs.pm'} = '1'; > > use CGI::Session::ErrorHandler; > use YAML::XS (); >-use Encode (); > > $CGI::Session::Serialize::yamlxs::VERSION = '0.1'; > @CGI::Session::Serialize::yamlxs::ISA = ( "CGI::Session::ErrorHandler" ); > > sub freeze { > my ($self, $data) = @_; >- return Encode::decode_utf8(YAML::XS::Dump($data)); >+ return YAML::XS::Dump($data); > } > > sub thaw { > my ($self, $string) = @_; >- return (YAML::XS::Load(Encode::encode_utf8($string)))[0]; >+ return (YAML::XS::Load($string))[0]; > } > # ******************************************************************** > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28489
:
121539
|
121541
|
121563
|
121564
|
121565
|
121570
|
121571
|
121584
|
121585
|
121624
|
121637
|
121638
|
121639
|
121640
|
121648
|
121650
|
121651
|
121652
|
121653
|
121654
|
121831
|
121832
|
121833
|
121834
|
121835
|
121848
|
121849
|
121850
|
121851
| 121852