Bugzilla – Attachment 121987 Details for
Bug 28565
Adding a new syspref for sharing through HEA should be simpler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28565: Simplify tests
Bug-28565-Simplify-tests.patch (text/plain), 7.80 KB, created by
David Nind
on 2021-06-15 11:11:48 UTC
(
hide
)
Description:
Bug 28565: Simplify tests
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-06-15 11:11:48 UTC
Size:
7.80 KB
patch
obsolete
>From 26c0f5f89543f5c2f8059b5d2498b0b47e0173ae Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 14 Jun 2021 17:45:53 -0300 >Subject: [PATCH] Bug 28565: Simplify tests > >This patch makes the tests for UsageStats. This way the tests don't need >to be adjusted everytime a syspref is added. > >To test: >1. Apply the first patch >2. Add some random syspref to C4::UsageStats >3. Run: > $ kshell > k$ prove t/db_dependent/UsageStats.t >=> FAIL: Things explode >4. Apply this patch >5. Repeat 3 >=> SUCCESS: It doesn't explode anymore! >6. Sign off :-D > >Signed-off-by: David Nind <david@davidnind.com> >--- > t/db_dependent/UsageStats.t | 244 +----------------------------------- > 1 file changed, 2 insertions(+), 242 deletions(-) > >diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t >index cf61f5c940..b97eb1c6cb 100755 >--- a/t/db_dependent/UsageStats.t >+++ b/t/db_dependent/UsageStats.t >@@ -347,248 +347,8 @@ sub construct_objects_needed { > sub mocking_systempreferences_to_a_set_value { > my $set_value = shift; > >- foreach ( >- qw/ >- AcqCreateItem >- AcqWarnOnDuplicateInvoice >- AcqViewBaskets >- BasketConfirmations >- OrderPdfFormat >- casAuthentication >- casLogout >- AllowPKIAuth >- DebugLevel >- CSVDelimiter >- noItemTypeImages >- OpacNoItemTypeImages >- virtualshelves >- AutoLocation >- IndependentBranches >- SessionStorage >- Persona >- AuthDisplayHierarchy >- AutoCreateAuthorities >- BiblioAddsAuthorities >- AuthorityMergeLimit >- AuthorityMergeMode >- UseAuthoritiesForTracings >- CatalogModuleRelink >- hide_marc >- IntranetBiblioDefaultView >- LabelMARCView >- OpacSuppression >- SeparateHoldings >- UseControlNumber >- advancedMARCeditor >- DefaultClassificationSource >- EasyAnalyticalRecords >- autoBarcode >- item-level_itypes >- marcflavour >- PrefillItem >- z3950NormalizeAuthor >- SpineLabelAutoPrint >- SpineLabelShowPrintOnBibDetails >- BlockReturnOfLostItems >- BlockReturnOfWithdrawnItems >- CalculateFinesOnReturn >- AgeRestrictionOverride >- AllFinesNeedOverride >- AllowFineOverride >- AllowItemsOnHoldCheckoutSIP >- AllowItemsOnHoldCheckoutSCO >- AllowNotForLoanOverride >- AllowRenewalLimitOverride >- AllowReturnToBranch >- AllowTooManyOverride >- AutomaticItemReturn >- AutoRemoveOverduesRestrictions >- CircControl >- HomeOrHoldingBranch >- HomeOrHoldingBranchReturn >- IssueLostItem >- IssuingInProcess >- ManInvInNoissuesCharge >- OverduesBlockCirc >- RenewalPeriodBase >- RenewalSendNotice >- RentalsInNoissuesCharge >- ReturnBeforeExpiry >- TransfersMaxDaysWarning >- UseBranchTransferLimits >- UseTransportCostMatrix >- UseCourseReserves >- finesCalendar >- FinesIncludeGracePeriod >- finesMode >- RefundLostOnReturnControl >- WhenLostChargeReplacementFee >- WhenLostForgiveFine >- AllowHoldDateInFuture >- AllowHoldPolicyOverride >- AllowHoldsOnDamagedItems >- AllowHoldsOnPatronsPossessions >- AutoResumeSuspendedHolds >- canreservefromotherbranches >- decreaseLoanHighHolds >- DisplayMultiPlaceHold >- emailLibrarianWhenHoldIsPlaced >- ExpireReservesMaxPickUpDelay >- OPACAllowHoldDateInFuture >- OPACAllowUserToChooseBranch >- ReservesControlBranch >- ReservesNeedReturns >- SuspendHoldsIntranet >- SuspendHoldsOpac >- TransferWhenCancelAllWaitingHolds >- AllowAllMessageDeletion >- AllowOfflineCirculation >- PatronAutoComplete >- CircAutoPrintQuickSlip >- DisplayClearScreenButton >- FilterBeforeOverdueReport >- FineNotifyAtCheckin >- itemBarcodeFallbackSearch >- itemBarcodeInputFilter >- previousIssuesDefaultSortOrder >- RecordLocalUseOnReturn >- soundon >- SpecifyDueDate >- todaysIssuesDefaultSortOrder >- UpdateTotalIssuesOnCirc >- UseTablesortForCirc >- WaitingNotifyAtCheckin >- SCOAllowCheckin >- AutoSelfCheckAllowed >- FRBRizeEditions >- OPACFRBRizeEditions >- AmazonCoverImages >- OPACAmazonCoverImages >- Babeltheque >- BakerTaylorEnabled >- GoogleJackets >- HTML5MediaEnabled >- LibraryThingForLibrariesEnabled >- LocalCoverImages >- OPACLocalCoverImages >- NovelistSelectEnabled >- OpenLibraryCovers >- OpenLibrarySearch >- SyndeticsEnabled >- TagsEnabled >- CalendarFirstDayOfWeek >- opaclanguagesdisplay >- AcquisitionLog >- AuthoritiesLog >- BorrowersLog >- CataloguingLog >- FinesLog >- IssueLog >- ClaimsLog >- ReturnLog >- SubscriptionLog >- BiblioDefaultView >- COinSinOPACResults >- DisplayOPACiconsXSLT >- hidelostitems >- HighlightOwnItemsOnOPAC >- OpacAddMastheadLibraryPulldown >- OPACDisplay856uAsImage >- OpacHighlightedWords >- OpacKohaUrl >- OpacMaintenance >- OpacPublic >- OpacSeparateHoldings >- OPACShowCheckoutName >- OpacShowFiltersPulldownMobile >- OPACShowHoldQueueDetails >- OpacShowRecentComments >- OPACShowUnusedAuthorities >- OpacStarRatings >- opacthemes >- OPACURLOpenInNewWindow >- OpacAuthorities >- opacbookbag >- OpacBrowser >- OpacBrowseResults >- OpacCloud >- OPACFinesTab >- OpacHoldNotes >- OpacItemLocation >- OpacPasswordChange >- OPACPatronDetails >- OPACpatronimages >- OPACPopupAuthorsSearch >- OpacTopissue >- opacuserlogin >- QuoteOfTheDay >- RequestOnOpac >- OPACComments >- ShowReviewer >- ShowReviewerPhoto >- SocialNetworks >- suggestion >- OpacAllowPublicListCreation >- OpacAllowSharingPrivateLists >- OpacRenewalAllowed >- OpacRenewalBranch >- OPACViewOthersSuggestions >- SearchMyLibraryFirst >- singleBranchMode >- AnonSuggestions >- EnableOpacSearchHistory >- OPACPrivacy >- opacreadinghistory >- TrackClicks >- PatronSelfRegistration >- OPACShelfBrowser >- AutoEmailOpacUser >- AutoEmailPrimaryAddress >- autoMemberNum >- BorrowerRenewalPeriodBase >- EnableBorrowerFiles >- EnhancedMessagingPreferences >- ExtendedPatronAttributes >- intranetreadinghistory >- patronimages >- TalkingTechItivaPhoneNotification >- uppercasesurnames >- IncludeSeeFromInSearches >- QueryAutoTruncate >- QueryFuzzy >- QueryStemming >- QueryWeightFields >- TraceCompleteSubfields >- TraceSubjectSubdivisions >- UseICUStyleQuotes >- defaultSortField >- displayFacetCount >- OPACdefaultSortField >- OPACItemsResultsDisplay >- expandedSearchOption >- IntranetNumbersPreferPhrase >- OPACNumbersPreferPhrase >- opacSerialDefaultTab >- RenewSerialAddsSuggestion >- RoutingListAddReserves >- RoutingSerials >- SubscriptionHistory >- Display856uAsImage >- DisplayIconsXSLT >- template >- yuipath >- HidePatronName >- intranetbookbag >- StaffDetailItemSelection >- viewISBD >- viewLabeledMARC >- viewMARC >- ILS-DI >- OAI-PMH >- version >- AudioAlerts >- / >- ) { >+ foreach ( @{ C4::UsageStats::_shared_preferences() } ) >+ { > t::lib::Mocks::mock_preference( $_, $set_value ); > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28565
:
121938
|
121939
|
121986
|
121987
|
122289
|
122353
|
122354
|
123167
|
123168