Bugzilla – Attachment 12200 Details for
Bug 7417
Include alternate forms from authorities in bibliographic searches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7417 follow-up: fix a perlcritic violation
Bug-7417-follow-up-fix-a-perlcritic-violation.patch (text/plain), 1.37 KB, created by
Jared Camins-Esakov
on 2012-09-13 17:44:46 UTC
(
hide
)
Description:
Bug 7417 follow-up: fix a perlcritic violation
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-09-13 17:44:46 UTC
Size:
1.37 KB
patch
obsolete
>From 2d267540ba58a2334b30c47f8c63b90ee3b6d329 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Thu, 13 Sep 2012 13:39:13 -0400 >Subject: [PATCH] Bug 7417 follow-up: fix a perlcritic violation > >--- > Koha/Authority.pm | 2 +- > Koha/Filter/MARC/EmbedSeeFromHeadings.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Authority.pm b/Koha/Authority.pm >index b64f8de..b07db92 100644 >--- a/Koha/Authority.pm >+++ b/Koha/Authority.pm >@@ -77,7 +77,7 @@ sub get_from_authid { > my ($authtypecode, $marcxml) = $sth->fetchrow; > my $record=eval {MARC::Record->new_from_xml(StripNonXmlChars($marcxml),'UTF-8', > (C4::Context->preference("marcflavour") eq "UNIMARC"?"UNIMARCAUTH":C4::Context->preference("marcflavour")))}; >- return undef if ($@); >+ return if ($@); > $record->encoding('UTF-8'); > > my $self = $class->SUPER::new( { authid => $authid, >diff --git a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm >index ea7e38b..fc35a74 100644 >--- a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm >+++ b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm >@@ -54,7 +54,7 @@ sub filter { > my $record = shift; > my $newrecord; > >- return undef unless defined $record; >+ return unless defined $record; > > if (ref $record eq 'ARRAY') { > my @recarray; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7417
:
11028
|
11253
|
11319
|
11362
|
11363
|
11364
|
11365
|
11366
|
11393
|
11419
|
11427
|
11441
|
11460
|
11465
|
12147
|
12148
|
12199
|
12200
|
12204