Bugzilla – Attachment 122359 Details for
Bug 28409
Category should be validated in opac-shelves.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28409: Adjust regression test
Bug-28409-Adjust-regression-test.patch (text/plain), 1.31 KB, created by
Jonathan Druart
on 2021-06-24 07:59:28 UTC
(
hide
)
Description:
Bug 28409: Adjust regression test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-24 07:59:28 UTC
Size:
1.31 KB
patch
obsolete
>From 18aecb93245c1ccecee7e35d3963910a4de446e7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 24 Jun 2021 09:55:23 +0200 >Subject: [PATCH] Bug 28409: Adjust regression test > >We are no longer expecting an URI escaped value but a corrected category >value, either 1 or 2. >--- > t/db_dependent/selenium/regressions.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index dd53935e6b5..a59739fa8c4 100755 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -251,7 +251,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > is( $alert_text, undef, 'No alert box displayed, even if evil intent' ); > > my $second_page = $driver->find_element('//div[@class="pages"]/span[@class="currentPage"]/following-sibling::a'); >- like( $second_page->get_attribute('href'), qr{category=2%22%3E%3Cscript%3Ealert%28%27booh%21%27%29%3C%2Fscript%3E}, 'The second page should display the variables and attributes correctly URI escaped' ); >+ like( $second_page->get_attribute('href'), qr{(?|&)category=2(&|$)}, 'The second page should display category without the invalid value' ); > > push @cleanup, $patron, $patron->category, $patron->library; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28409
:
121267
|
121268
|
121281
|
121282
|
121308
|
121487
|
121488
|
122358
| 122359