View | Details | Raw Unified | Return to bug 17600
Collapse All | Expand All

(-)a/C4/Auth.pm (-6 / +8 lines)
Lines 26-32 use JSON qw/encode_json/; Link Here
26
use URI::Escape;
26
use URI::Escape;
27
use CGI::Session;
27
use CGI::Session;
28
28
29
require Exporter;
30
use C4::Context;
29
use C4::Context;
31
use C4::Templates;    # to get the template
30
use C4::Templates;    # to get the template
32
use C4::Languages;
31
use C4::Languages;
Lines 50-57 use Net::CIDR; Link Here
50
use C4::Log qw/logaction/;
49
use C4::Log qw/logaction/;
51
50
52
# use utf8;
51
# use utf8;
53
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $debug $ldap $cas $caslogout);
52
use vars qw($debug $ldap $cas $caslogout);
54
53
our (@ISA, @EXPORT_OK);
55
BEGIN {
54
BEGIN {
56
    sub psgi_env { any { /^psgi\./ } keys %ENV }
55
    sub psgi_env { any { /^psgi\./ } keys %ENV }
57
56
Lines 63-74 BEGIN { Link Here
63
    C4::Context->set_remote_address;
62
    C4::Context->set_remote_address;
64
63
65
    $debug     = $ENV{DEBUG};
64
    $debug     = $ENV{DEBUG};
66
    @ISA       = qw(Exporter);
65
    require Exporter;
67
    @EXPORT    = qw(&checkauth &get_template_and_user &haspermission &get_user_subpermissions);
66
    @ISA = qw(Exporter);
67
68
    @EXPORT_OK = qw(&check_api_auth &get_session &check_cookie_auth &checkpw &checkpw_internal &checkpw_hash
68
    @EXPORT_OK = qw(&check_api_auth &get_session &check_cookie_auth &checkpw &checkpw_internal &checkpw_hash
69
      &get_all_subpermissions &get_user_subpermissions track_login_daily &in_iprange
69
      &get_all_subpermissions &get_user_subpermissions track_login_daily &in_iprange
70
      &get_template_and_user
70
    );
71
    );
71
    %EXPORT_TAGS = ( EditPermissions => [qw(get_all_subpermissions get_user_subpermissions)] );
72
73
    $debug     = $ENV{DEBUG};
72
    $ldap      = C4::Context->config('useldapserver') || 0;
74
    $ldap      = C4::Context->config('useldapserver') || 0;
73
    $cas       = C4::Context->preference('casAuthentication');
75
    $cas       = C4::Context->preference('casAuthentication');
74
    $caslogout = C4::Context->preference('casLogout');
76
    $caslogout = C4::Context->preference('casLogout');
(-)a/C4/Auth_with_cas.pm (-2 / +3 lines)
Lines 28-40 use FindBin; Link Here
28
use YAML::XS;
28
use YAML::XS;
29
29
30
30
31
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $debug);
31
use vars qw($debug);
32
our (@ISA, @EXPORT_OK);
32
33
33
BEGIN {
34
BEGIN {
34
    require Exporter;
35
    require Exporter;
35
    $debug = $ENV{DEBUG};
36
    $debug = $ENV{DEBUG};
36
    @ISA   = qw(Exporter);
37
    @ISA   = qw(Exporter);
37
    @EXPORT = qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url logout_if_required);
38
    @EXPORT_OK = qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url logout_if_required);
38
}
39
}
39
my $defaultcasserver;
40
my $defaultcasserver;
40
my $casservers;
41
my $casservers;
(-)a/C4/Auth_with_ldap.pm (-3 / +3 lines)
Lines 29-40 use List::MoreUtils qw( any ); Link Here
29
use Net::LDAP;
29
use Net::LDAP;
30
use Net::LDAP::Filter;
30
use Net::LDAP::Filter;
31
31
32
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $debug);
32
use vars qw($debug);
33
33
our (@ISA, @EXPORT_OK);
34
BEGIN {
34
BEGIN {
35
	require Exporter;
35
	require Exporter;
36
	@ISA    = qw(Exporter);
36
	@ISA    = qw(Exporter);
37
	@EXPORT = qw( checkpw_ldap );
37
	@EXPORT_OK = qw( checkpw_ldap );
38
}
38
}
39
39
40
# Redefine checkpw_ldap:
40
# Redefine checkpw_ldap:
(-)a/C4/Auth_with_shibboleth.pm (-3 / +3 lines)
Lines 28-40 use Carp; Link Here
28
use CGI;
28
use CGI;
29
use List::MoreUtils qw(any);
29
use List::MoreUtils qw(any);
30
30
31
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $debug);
31
use vars qw($debug);
32
32
our (@ISA, @EXPORT_OK);
33
BEGIN {
33
BEGIN {
34
    require Exporter;
34
    require Exporter;
35
    $debug   = $ENV{DEBUG};
35
    $debug   = $ENV{DEBUG};
36
    @ISA     = qw(Exporter);
36
    @ISA     = qw(Exporter);
37
    @EXPORT =
37
    @EXPORT_OK =
38
      qw(shib_ok logout_shib login_shib_url checkpw_shib get_login_shib);
38
      qw(shib_ok logout_shib login_shib_url checkpw_shib get_login_shib);
39
}
39
}
40
40
(-)a/C4/Barcodes.pm (-7 lines)
Lines 28-42 use C4::Barcodes::annual; Link Here
28
use C4::Barcodes::incremental;
28
use C4::Barcodes::incremental;
29
use C4::Barcodes::EAN13;
29
use C4::Barcodes::EAN13;
30
30
31
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
32
use vars qw($max $prefformat);
31
use vars qw($max $prefformat);
33
32
34
BEGIN {
35
	require Exporter;
36
    @ISA = qw(Exporter);
37
    @EXPORT_OK = qw();
38
}
39
40
sub _prefformat {
33
sub _prefformat {
41
	unless (defined $prefformat) {
34
	unless (defined $prefformat) {
42
		unless ($prefformat = C4::Context->preference('autoBarcode')) {
35
		unless ($prefformat = C4::Context->preference('autoBarcode')) {
(-)a/C4/Biblio.pm (-5 / +5 lines)
Lines 21-32 package C4::Biblio; Link Here
21
21
22
use Modern::Perl;
22
use Modern::Perl;
23
23
24
use vars qw(@ISA @EXPORT);
24
use vars qw(@ISA @EXPORT_OK);
25
BEGIN {
25
BEGIN {
26
    require Exporter;
26
    require Exporter;
27
    @ISA = qw(Exporter);
27
    @ISA = qw(Exporter);
28
28
29
    @EXPORT = qw(
29
    @EXPORT_OK = qw(
30
        AddBiblio
30
        AddBiblio
31
        GetBiblioData
31
        GetBiblioData
32
        GetMarcBiblio
32
        GetMarcBiblio
Lines 69-75 BEGIN { Link Here
69
    # those functions are exported but should not be used
69
    # those functions are exported but should not be used
70
    # they are useful in a few circumstances, so they are exported,
70
    # they are useful in a few circumstances, so they are exported,
71
    # but don't use them unless you are a core developer ;-)
71
    # but don't use them unless you are a core developer ;-)
72
    push @EXPORT, qw(
72
    push @EXPORT_OK, qw(
73
      ModBiblioMarc
73
      ModBiblioMarc
74
    );
74
    );
75
}
75
}
Lines 88-95 use Module::Load::Conditional qw(can_load); Link Here
88
use C4::Koha;
88
use C4::Koha;
89
use C4::Log;    # logaction
89
use C4::Log;    # logaction
90
use C4::Budgets;
90
use C4::Budgets;
91
use C4::ClassSource;
91
use C4::ClassSource qw( GetClassSort );
92
use C4::Charset;
92
use C4::Charset qw( SetUTF8Flag );
93
use C4::Linker;
93
use C4::Linker;
94
use C4::OAI::Sets;
94
use C4::OAI::Sets;
95
95
(-)a/C4/Breeding.pm (-3 / +2 lines)
Lines 32-43 use C4::Languages; Link Here
32
use Koha::Database;
32
use Koha::Database;
33
use Koha::XSLT::Base;
33
use Koha::XSLT::Base;
34
34
35
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
35
our (@ISA, @EXPORT_OK);
36
37
BEGIN {
36
BEGIN {
38
	require Exporter;
37
	require Exporter;
39
	@ISA = qw(Exporter);
38
	@ISA = qw(Exporter);
40
    @EXPORT = qw(&BreedingSearch &Z3950Search &Z3950SearchAuth);
39
    @EXPORT_OK = qw(&BreedingSearch &Z3950Search &Z3950SearchAuth);
41
}
40
}
42
41
43
=head1 NAME
42
=head1 NAME
(-)a/C4/Charset.pm (-3 / +2 lines)
Lines 26-37 use Encode qw( decode encode is_utf8 ); Link Here
26
26
27
use Koha::Logger;
27
use Koha::Logger;
28
28
29
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
29
our (@ISA, @EXPORT_OK);
30
31
BEGIN {
30
BEGIN {
32
    require Exporter;
31
    require Exporter;
33
    @ISA    = qw(Exporter);
32
    @ISA    = qw(Exporter);
34
    @EXPORT = qw(
33
    @EXPORT_OK = qw(
35
        NormalizeString
34
        NormalizeString
36
        IsStringUTF8ish
35
        IsStringUTF8ish
37
        MarcToUTF8Record
36
        MarcToUTF8Record
(-)a/C4/Circulation.pm (-51 / +40 lines)
Lines 75-132 use Date::Calc qw( Link Here
75
  Day_of_Week
75
  Day_of_Week
76
  Add_Delta_Days
76
  Add_Delta_Days
77
);
77
);
78
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
78
our (@ISA, @EXPORT_OK);
79
80
BEGIN {
79
BEGIN {
81
	require Exporter;
80
82
	@ISA    = qw(Exporter);
81
    require Exporter;
83
82
    @ISA = qw(Exporter);
84
	# FIXME subs that should probably be elsewhere
83
85
	push @EXPORT, qw(
84
    # FIXME subs that should probably be elsewhere
86
		&barcodedecode
85
    push @EXPORT_OK, qw(
87
        &LostItem
86
      &barcodedecode
88
        &ReturnLostItem
87
      &LostItem
89
        &GetPendingOnSiteCheckouts
88
      &ReturnLostItem
90
	);
89
      &GetPendingOnSiteCheckouts
91
90
92
	# subs to deal with issuing a book
91
      &CanBookBeIssued
93
	push @EXPORT, qw(
92
      &CanBookBeRenewed
94
		&CanBookBeIssued
93
      &AddIssue
95
		&CanBookBeRenewed
94
      &AddRenewal
96
		&AddIssue
95
      &GetRenewCount
97
		&AddRenewal
96
      &GetSoonestRenewDate
98
		&GetRenewCount
97
      &GetLatestAutoRenewDate
99
        &GetSoonestRenewDate
98
      &GetIssuingCharges
100
        &GetLatestAutoRenewDate
99
      &GetBranchBorrowerCircRule
101
		&GetIssuingCharges
100
      &GetBranchItemRule
102
        &GetBranchBorrowerCircRule
101
      &GetBiblioIssues
103
        &GetBranchItemRule
102
      &GetOpenIssue
104
		&GetOpenIssue
103
      &CheckIfIssuedToPatron
105
        &CheckIfIssuedToPatron
104
      &IsItemIssued
106
        &IsItemIssued
105
      GetTopIssues
107
        GetTopIssues
106
108
	);
107
      &AddReturn
109
108
      &MarkIssueReturned
110
	# subs to deal with returns
109
111
	push @EXPORT, qw(
110
      &transferbook
112
		&AddReturn
111
      &GetTransfers
113
        &MarkIssueReturned
112
      &GetTransfersFromTo
114
	);
113
      &updateWrongTransfer
115
114
      &IsBranchTransferAllowed
116
	# subs to deal with transfers
115
      &CreateBranchTransferLimit
117
	push @EXPORT, qw(
116
      &DeleteBranchTransferLimits
118
		&transferbook
117
      &TransferSlip
119
		&GetTransfers
118
120
		&GetTransfersFromTo
121
		&updateWrongTransfer
122
                &IsBranchTransferAllowed
123
                &CreateBranchTransferLimit
124
                &DeleteBranchTransferLimits
125
        &TransferSlip
126
	);
127
128
    # subs to deal with offline circulation
129
    push @EXPORT, qw(
130
      &GetOfflineOperations
119
      &GetOfflineOperations
131
      &GetOfflineOperation
120
      &GetOfflineOperation
132
      &AddOfflineOperation
121
      &AddOfflineOperation
(-)a/C4/ClassSortRoutine.pm (-9 / +9 lines)
Lines 20-31 package C4::ClassSortRoutine; Link Here
20
use strict;
20
use strict;
21
use warnings;
21
use warnings;
22
22
23
require Exporter;
24
use Class::Factory::Util;
23
use Class::Factory::Util;
25
use C4::Context;
24
use C4::Context;
26
25
27
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
26
our (@ISA, @EXPORT_OK);
28
27
BEGIN {
28
    require Exporter;
29
    @ISA    = qw(Exporter);
30
    @EXPORT_OK = qw(
31
       &GetSortRoutineNames
32
       &GetClassSortKey
33
    );
34
}
29
35
30
=head1 NAME 
36
=head1 NAME 
31
37
Lines 40-51 use C4::ClassSortRoutine; Link Here
40
46
41
=cut
47
=cut
42
48
43
@ISA    = qw(Exporter);
44
@EXPORT = qw(
45
   &GetSortRoutineNames
46
   &GetClassSortKey
47
);
48
49
# initialization code
49
# initialization code
50
my %loaded_routines = ();
50
my %loaded_routines = ();
51
my @sort_routines = GetSortRoutineNames();
51
my @sort_routines = GetSortRoutineNames();
(-)a/C4/ClassSource.pm (-16 / +13 lines)
Lines 20-31 package C4::ClassSource; Link Here
20
use strict;
20
use strict;
21
use warnings;
21
use warnings;
22
22
23
require Exporter;
24
use C4::Context;
23
use C4::Context;
25
use C4::ClassSortRoutine;
24
use C4::ClassSortRoutine qw( GetClassSortKey );
26
25
27
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
26
our (@ISA, @EXPORT_OK);
28
27
BEGIN {
28
    require Exporter;
29
    @ISA    = qw(Exporter);
30
    @EXPORT_OK = qw(
31
        &GetClassSources
32
        &GetClassSource
33
        &GetClassSortRule
34
        &GetClassSort
35
    );
36
}
29
37
30
=head1 NAME
38
=head1 NAME
31
39
Lines 44-60 sources and sorting rules. Link Here
44
52
45
=cut
53
=cut
46
54
47
48
@ISA    = qw(Exporter);
49
@EXPORT = qw(
50
    &GetClassSources
51
    &GetClassSource
52
    &GetClassSortRule
53
54
    &GetClassSort
55
56
);
57
58
=head2 GetClassSources
55
=head2 GetClassSources
59
56
60
  my $sources = GetClassSources();
57
  my $sources = GetClassSources();
(-)a/C4/CourseReserves.pm (-3 / +3 lines)
Lines 27-34 use Koha::Course::Instructors; Link Here
27
use Koha::Course::Items;
27
use Koha::Course::Items;
28
use Koha::Course::Reserves;
28
use Koha::Course::Reserves;
29
29
30
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG @FIELDS);
30
use vars qw($DEBUG @FIELDS);
31
31
our (@ISA, @EXPORT_OK);
32
BEGIN {
32
BEGIN {
33
    require Exporter;
33
    require Exporter;
34
    @ISA       = qw(Exporter);
34
    @ISA       = qw(Exporter);
Lines 53-59 BEGIN { Link Here
53
53
54
      &GetItemCourseReservesInfo
54
      &GetItemCourseReservesInfo
55
    );
55
    );
56
    %EXPORT_TAGS = ( 'all' => \@EXPORT_OK );
56
    #%EXPORT_TAGS = ( 'all' => \@EXPORT_OK );
57
57
58
    $DEBUG = 0;
58
    $DEBUG = 0;
59
    @FIELDS = ( 'itype', 'ccode', 'homebranch', 'holdingbranch', 'location' );
59
    @FIELDS = ( 'itype', 'ccode', 'homebranch', 'holdingbranch', 'location' );
(-)a/C4/External/BakerTaylor.pm (-5 / +6 lines)
Lines 26-39 use C4::Context; Link Here
26
26
27
use Modern::Perl;
27
use Modern::Perl;
28
28
29
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION);
29
use vars qw(%EXPORT_TAGS $VERSION);
30
our (@ISA, @EXPORT_OK);
30
31
31
BEGIN {
32
BEGIN {
32
	require Exporter;
33
    require Exporter;
33
	@ISA = qw(Exporter);
34
    @ISA = qw(Exporter);
34
    $VERSION = 3.07.00.049;
35
    $VERSION = 3.07.00.049;
35
	@EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link);
36
    @EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link);
36
	%EXPORT_TAGS = (all=>\@EXPORT_OK);
37
#	%EXPORT_TAGS = (all=>\@EXPORT_OK);
37
}
38
}
38
39
39
# These variables are plack safe: they are initialized each time
40
# These variables are plack safe: they are initialized each time
(-)a/C4/HoldsQueue.pm (-1 / +1 lines)
Lines 37-43 use List::Util qw(shuffle); Link Here
37
use List::MoreUtils qw(any);
37
use List::MoreUtils qw(any);
38
use Data::Dumper;
38
use Data::Dumper;
39
39
40
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
40
our (@ISA, @EXPORT_OK);
41
BEGIN {
41
BEGIN {
42
    require Exporter;
42
    require Exporter;
43
    @ISA = qw(Exporter);
43
    @ISA = qw(Exporter);
(-)a/C4/ImportBatch.pm (-3 / +2 lines)
Lines 31-42 use Koha::Items; Link Here
31
use Koha::Plugins::Handler;
31
use Koha::Plugins::Handler;
32
use Koha::Logger;
32
use Koha::Logger;
33
33
34
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
34
our (@ISA, @EXPORT_OK);
35
36
BEGIN {
35
BEGIN {
37
	require Exporter;
36
	require Exporter;
38
	@ISA    = qw(Exporter);
37
	@ISA    = qw(Exporter);
39
	@EXPORT = qw(
38
	@EXPORT_OK = qw(
40
    GetZ3950BatchId
39
    GetZ3950BatchId
41
    GetWebserviceBatchId
40
    GetWebserviceBatchId
42
    GetImportRecordMarc
41
    GetImportRecordMarc
(-)a/C4/ImportExportFramework.pm (-3 / +2 lines)
Lines 29-40 use List::MoreUtils qw(indexes); Link Here
29
use C4::Context;
29
use C4::Context;
30
use Koha::Logger;
30
use Koha::Logger;
31
31
32
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
32
our (@ISA, @EXPORT_OK);
33
34
BEGIN {
33
BEGIN {
35
    require Exporter;
34
    require Exporter;
36
    @ISA    = qw(Exporter);
35
    @ISA    = qw(Exporter);
37
    @EXPORT = qw(
36
    @EXPORT_OK = qw(
38
        &ExportFramework
37
        &ExportFramework
39
        &ImportFramework
38
        &ImportFramework
40
        &createODS
39
        &createODS
(-)a/C4/InstallAuth.pm (-7 / +8 lines)
Lines 29-41 use C4::Output; Link Here
29
use C4::Templates;
29
use C4::Templates;
30
use C4::Koha;
30
use C4::Koha;
31
31
32
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
32
our (@ISA, @EXPORT_OK);
33
33
BEGIN {
34
@ISA    = qw(Exporter);
34
    @ISA    = qw(Exporter);
35
@EXPORT = qw(
35
    @EXPORT_OK = qw(
36
  &checkauth
36
      &checkauth
37
  &get_template_and_user
37
      &get_template_and_user
38
);
38
    );
39
}
39
40
40
=head1 NAME
41
=head1 NAME
41
42
(-)a/C4/Items.pm (-3 / +3 lines)
Lines 20-31 package C4::Items; Link Here
20
20
21
use Modern::Perl;
21
use Modern::Perl;
22
22
23
use vars qw(@ISA @EXPORT);
23
our (@ISA, @EXPORT_OK);
24
BEGIN {
24
BEGIN {
25
    require Exporter;
25
    require Exporter;
26
    @ISA = qw(Exporter);
26
    @ISA = qw(Exporter);
27
27
28
    @EXPORT = qw(
28
    @EXPORT_OK = qw(
29
        AddItemFromMarc
29
        AddItemFromMarc
30
        AddItemBatchFromMarc
30
        AddItemBatchFromMarc
31
        ModItemFromMarc
31
        ModItemFromMarc
Lines 51-57 use Carp; Link Here
51
use Try::Tiny;
51
use Try::Tiny;
52
use C4::Context;
52
use C4::Context;
53
use C4::Koha;
53
use C4::Koha;
54
use C4::Biblio;
54
use C4::Biblio qw( GetFrameworkCode );
55
use Koha::DateUtils;
55
use Koha::DateUtils;
56
use MARC::Record;
56
use MARC::Record;
57
use C4::ClassSource;
57
use C4::ClassSource;
(-)a/C4/Koha.pm (-9 / +7 lines)
Lines 30-41 use Koha::MarcSubfieldStructures; Link Here
30
use Business::ISBN;
30
use Business::ISBN;
31
use Business::ISSN;
31
use Business::ISSN;
32
use autouse 'Data::cselectall_arrayref' => qw(Dumper);
32
use autouse 'Data::cselectall_arrayref' => qw(Dumper);
33
use vars qw(@ISA @EXPORT @EXPORT_OK $DEBUG);
33
our (@ISA, @EXPORT_OK);
34
35
BEGIN {
34
BEGIN {
36
	require Exporter;
35
    require Exporter;
37
	@ISA    = qw(Exporter);
36
    @ISA    = qw(Exporter);
38
	@EXPORT = qw(
37
    @EXPORT_OK = qw(
39
        &GetItemTypesCategorized
38
        &GetItemTypesCategorized
40
        &getallthemes
39
        &getallthemes
41
        &getFacets
40
        &getFacets
Lines 57-65 BEGIN { Link Here
57
        &GetVariationsOfISSNs
56
        &GetVariationsOfISSNs
58
        &NormalizeISSN
57
        &NormalizeISSN
59
58
60
		$DEBUG
59
        GetDailyQuote
61
	);
60
62
	$DEBUG = 0;
61
    );
63
}
62
}
64
63
65
=head1 NAME
64
=head1 NAME
Lines 249-255 sub getImageSets { Link Here
249
    my @imagesets = (); # list of hasrefs of image set data to pass to template
248
    my @imagesets = (); # list of hasrefs of image set data to pass to template
250
    my @subdirectories = _getSubdirectoryNames( $paths->{'staff'}{'filesystem'} );
249
    my @subdirectories = _getSubdirectoryNames( $paths->{'staff'}{'filesystem'} );
251
    foreach my $imagesubdir ( @subdirectories ) {
250
    foreach my $imagesubdir ( @subdirectories ) {
252
    warn $imagesubdir if $DEBUG;
253
        my @imagelist     = (); # hashrefs of image info
251
        my @imagelist     = (); # hashrefs of image info
254
        my @imagenames = _getImagesFromDirectory( File::Spec->catfile( $paths->{'staff'}{'filesystem'}, $imagesubdir ) );
252
        my @imagenames = _getImagesFromDirectory( File::Spec->catfile( $paths->{'staff'}{'filesystem'}, $imagesubdir ) );
255
        my $imagesetactive = 0;
253
        my $imagesetactive = 0;
(-)a/C4/Languages.pm (-4 / +4 lines)
Lines 28-45 use List::MoreUtils qw( any ); Link Here
28
use C4::Context;
28
use C4::Context;
29
use Koha::Caches;
29
use Koha::Caches;
30
use Koha::Cache::Memory::Lite;
30
use Koha::Cache::Memory::Lite;
31
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG);
31
use vars qw($DEBUG);
32
32
our (@ISA, @EXPORT_OK);
33
BEGIN {
33
BEGIN {
34
    require Exporter;
34
    require Exporter;
35
    @ISA    = qw(Exporter);
35
    @ISA    = qw(Exporter);
36
    @EXPORT = qw(
36
    @EXPORT_OK = qw(
37
        &getFrameworkLanguages
37
        &getFrameworkLanguages
38
        &getTranslatedLanguages
38
        &getTranslatedLanguages
39
        &getLanguages
39
        &getLanguages
40
        &getAllLanguages
40
        &getAllLanguages
41
    );
41
    );
42
    @EXPORT_OK = qw(getFrameworkLanguages getTranslatedLanguages getAllLanguages getLanguages get_bidi regex_lang_subtags language_get_description accept_language getlanguage);
42
    push @EXPORT_OK, qw(getFrameworkLanguages getTranslatedLanguages getAllLanguages getLanguages get_bidi regex_lang_subtags language_get_description accept_language getlanguage);
43
    $DEBUG = 0;
43
    $DEBUG = 0;
44
}
44
}
45
45
(-)a/C4/Letters.pm (-3 / +2 lines)
Lines 43-54 use Koha::Patrons; Link Here
43
use Koha::SMTP::Servers;
43
use Koha::SMTP::Servers;
44
use Koha::Subscriptions;
44
use Koha::Subscriptions;
45
45
46
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
46
our (@ISA, @EXPORT_OK);
47
48
BEGIN {
47
BEGIN {
49
    require Exporter;
48
    require Exporter;
50
    @ISA = qw(Exporter);
49
    @ISA = qw(Exporter);
51
    @EXPORT = qw(
50
    @EXPORT_OK = qw(
52
        &EnqueueLetter &GetLetters &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter &GetPreparedLetter &GetWrappedLetter &SendAlerts &GetPrintMessages &GetMessageTransportTypes
51
        &EnqueueLetter &GetLetters &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter &GetPreparedLetter &GetWrappedLetter &SendAlerts &GetPrintMessages &GetMessageTransportTypes
53
    );
52
    );
54
}
53
}
(-)a/C4/Members.pm (-6 / +5 lines)
Lines 44-67 use Koha::List::Patron; Link Here
44
use Koha::Patrons;
44
use Koha::Patrons;
45
use Koha::Patron::Categories;
45
use Koha::Patron::Categories;
46
46
47
our (@ISA,@EXPORT,@EXPORT_OK,$debug);
47
our ($debug);
48
48
49
our (@ISA, @EXPORT_OK);
49
BEGIN {
50
BEGIN {
50
    $debug = $ENV{DEBUG} || 0;
51
    $debug = $ENV{DEBUG} || 0;
51
    require Exporter;
52
    require Exporter;
52
    @ISA = qw(Exporter);
53
    @ISA = qw(Exporter);
53
    #Get data
54
    @EXPORT_OK = qw(
54
    push @EXPORT, qw(
55
        &GetMemberDetails
56
        &GetMember
55
57
56
        &GetAllIssues
58
        &GetAllIssues
57
59
58
        &GetBorrowersToExpunge
60
        &GetBorrowersToExpunge
59
61
60
        &IssueSlip
62
        &IssueSlip
61
    );
62
63
63
    #Check data
64
    push @EXPORT, qw(
65
        &checkuserpassword
64
        &checkuserpassword
66
        &checkcardnumber
65
        &checkcardnumber
67
    );
66
    );
(-)a/C4/Members/Statistics.pm (-2 / +2 lines)
Lines 26-39 use Modern::Perl; Link Here
26
26
27
use C4::Context;
27
use C4::Context;
28
28
29
our ( @ISA, @EXPORT, @EXPORT_OK, $debug );
29
our ( @ISA, @EXPORT_OK, $debug );
30
30
31
BEGIN {
31
BEGIN {
32
    $debug = $ENV{DEBUG} || 0;
32
    $debug = $ENV{DEBUG} || 0;
33
    require Exporter;
33
    require Exporter;
34
    @ISA = qw(Exporter);
34
    @ISA = qw(Exporter);
35
35
36
    push @EXPORT, qw(
36
    @EXPORT_OK = qw(
37
        &GetTotalIssuesTodayByBorrower
37
        &GetTotalIssuesTodayByBorrower
38
        &GetTotalIssuesReturnedTodayByBorrower
38
        &GetTotalIssuesReturnedTodayByBorrower
39
        &GetPrecedentStateByBorrower
39
        &GetPrecedentStateByBorrower
(-)a/C4/Output.pm (-12 / +10 lines)
Lines 34-59 use C4::Auth qw(get_template_and_user); Link Here
34
use C4::Context;
34
use C4::Context;
35
use C4::Templates;
35
use C4::Templates;
36
36
37
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
37
our (@ISA, @EXPORT_OK);
38
38
39
BEGIN {
39
BEGIN {
40
    require Exporter;
40
    require Exporter;
41
41
42
 @ISA    = qw(Exporter);
42
    @ISA    = qw(Exporter);
43
    @EXPORT_OK = qw(&is_ajax ajax_fail); # More stuff should go here instead
43
    @EXPORT_OK, qw(
44
    %EXPORT_TAGS = ( all =>[qw(setlanguagecookie pagination_bar parametrized_url
44
        is_ajax
45
                                &output_with_http_headers &output_ajax_with_http_headers &output_html_with_http_headers)],
45
        ajax_fail
46
                    ajax =>[qw(&output_with_http_headers &output_ajax_with_http_headers is_ajax)],
47
                    html =>[qw(&output_with_http_headers &output_html_with_http_headers)]
48
                );
49
    push @EXPORT, qw(
50
        setlanguagecookie getlanguagecookie pagination_bar parametrized_url
46
        setlanguagecookie getlanguagecookie pagination_bar parametrized_url
51
    );
52
    push @EXPORT, qw(
53
        &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers
47
        &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers
54
        &output_and_exit_if_error &output_and_exit &output_error
48
        &output_and_exit_if_error &output_and_exit &output_error
55
    );
49
    );
56
50
#    %EXPORT_TAGS = ( all =>[qw(setlanguagecookie pagination_bar parametrized_url
51
#                                &output_with_http_headers &output_ajax_with_http_headers &output_html_with_http_headers)],
52
#                    ajax =>[qw(&output_with_http_headers &output_ajax_with_http_headers is_ajax)],
53
#                    html =>[qw(&output_with_http_headers &output_html_with_http_headers)]
54
#                );
57
}
55
}
58
56
59
=head1 NAME
57
=head1 NAME
(-)a/C4/Overdues.pm (-7 / +2 lines)
Lines 37-50 use Koha::Account::Lines; Link Here
37
use Koha::Account::Offsets;
37
use Koha::Account::Offsets;
38
use Koha::Libraries;
38
use Koha::Libraries;
39
39
40
use vars qw(@ISA @EXPORT);
40
our (@ISA, @EXPORT_OK);
41
42
BEGIN {
41
BEGIN {
43
    require Exporter;
42
    require Exporter;
44
    @ISA = qw(Exporter);
43
    @ISA = qw(Exporter);
45
44
46
    # subs to rename (and maybe merge some...)
45
    # subs to rename (and maybe merge some...)
47
    push @EXPORT, qw(
46
    @EXPORT_OK = qw(
48
      &CalcFine
47
      &CalcFine
49
      &Getoverdues
48
      &Getoverdues
50
      &checkoverdues
49
      &checkoverdues
Lines 54-63 BEGIN { Link Here
54
      &GetOverduesForBranch
53
      &GetOverduesForBranch
55
      &GetOverdueMessageTransportTypes
54
      &GetOverdueMessageTransportTypes
56
      &parse_overdues_letter
55
      &parse_overdues_letter
57
    );
58
59
    # subs to move to Circulation.pm
60
    push @EXPORT, qw(
61
      &GetIssuesIteminfo
56
      &GetIssuesIteminfo
62
    );
57
    );
63
}
58
}
(-)a/C4/Reports.pm (-2 / +2 lines)
Lines 20-32 package C4::Reports; Link Here
20
use Modern::Perl;
20
use Modern::Perl;
21
use CGI qw ( -utf8 );
21
use CGI qw ( -utf8 );
22
22
23
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
24
use C4::Context;
23
use C4::Context;
25
24
25
our (@ISA, @EXPORT_OK);
26
BEGIN {
26
BEGIN {
27
    require Exporter;
27
    require Exporter;
28
    @ISA = qw(Exporter);
28
    @ISA = qw(Exporter);
29
    @EXPORT = qw(
29
    @EXPORT_OK = qw(
30
        GetDelimiterChoices
30
        GetDelimiterChoices
31
    );
31
    );
32
}
32
}
(-)a/C4/Reports/Guided.pm (-2 / +2 lines)
Lines 22-28 use CGI qw ( -utf8 ); Link Here
22
use Carp;
22
use Carp;
23
use JSON qw( from_json );
23
use JSON qw( from_json );
24
24
25
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
26
use C4::Context;
25
use C4::Context;
27
use C4::Templates qw/themelanguage/;
26
use C4::Templates qw/themelanguage/;
28
use C4::Koha;
27
use C4::Koha;
Lines 39-48 use Koha::AuthorisedValues; Link Here
39
use Koha::Patron::Categories;
38
use Koha::Patron::Categories;
40
use Koha::SharedContent;
39
use Koha::SharedContent;
41
40
41
our (@ISA, @EXPORT_OK);
42
BEGIN {
42
BEGIN {
43
    require Exporter;
43
    require Exporter;
44
    @ISA    = qw(Exporter);
44
    @ISA    = qw(Exporter);
45
    @EXPORT = qw(
45
    @EXPORT_OK = qw(
46
      get_report_types get_report_areas get_report_groups get_columns build_query get_criteria
46
      get_report_types get_report_areas get_report_groups get_columns build_query get_criteria
47
      save_report get_saved_reports execute_query
47
      save_report get_saved_reports execute_query
48
      get_column_type get_distinct_values save_dictionary get_from_dictionary
48
      get_column_type get_distinct_values save_dictionary get_from_dictionary
(-)a/C4/Reserves.pm (-4 / +4 lines)
Lines 51-58 use Carp; Link Here
51
use Data::Dumper;
51
use Data::Dumper;
52
use List::MoreUtils qw( firstidx any );
52
use List::MoreUtils qw( firstidx any );
53
53
54
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
55
56
=head1 NAME
54
=head1 NAME
57
55
58
C4::Reserves - Koha functions for dealing with reservation.
56
C4::Reserves - Koha functions for dealing with reservation.
Lines 99-108 This modules provides somes functions to deal with reservations. Link Here
99
97
100
=cut
98
=cut
101
99
100
our (@ISA, @EXPORT_OK);
102
BEGIN {
101
BEGIN {
103
    require Exporter;
102
    require Exporter;
104
    @ISA = qw(Exporter);
103
    @ISA = qw(Exporter);
105
    @EXPORT = qw(
104
    @EXPORT_OK = qw(
106
        &AddReserve
105
        &AddReserve
107
106
108
        &GetReserveStatus
107
        &GetReserveStatus
Lines 140-147 BEGIN { Link Here
140
        IsItemOnHoldAndFound
139
        IsItemOnHoldAndFound
141
140
142
        GetMaxPatronHoldsForRecord
141
        GetMaxPatronHoldsForRecord
142
143
        MergeHolds
143
    );
144
    );
144
    @EXPORT_OK = qw( MergeHolds );
145
}
145
}
146
146
147
=head2 AddReserve
147
=head2 AddReserve
(-)a/C4/SIP/Sip/Checksum.pm (-3 / +6 lines)
Lines 1-12 Link Here
1
package C4::SIP::Sip::Checksum;
1
package C4::SIP::Sip::Checksum;
2
2
3
use Exporter;
4
use strict;
3
use strict;
5
use warnings;
4
use warnings;
6
5
7
our @ISA = qw(Exporter);
6
our (@ISA, @EXPORT_OK);
8
our @EXPORT_OK = qw(checksum verify_cksum);
9
our $debug = 0;
7
our $debug = 0;
8
BEGIN {
9
    require Exporter;
10
    @ISA = qw(Exporter);
11
    @EXPORT_OK = qw(checksum verify_cksum);
12
}
10
13
11
sub checksum {
14
sub checksum {
12
    my $pkt = shift;
15
    my $pkt = shift;
(-)a/C4/Scheduler.pm (-2 / +2 lines)
Lines 19-32 package C4::Scheduler; Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
23
use C4::Context;
22
use C4::Context;
24
use Schedule::At;
23
use Schedule::At;
25
24
25
our (@ISA, @EXPORT_OK);
26
BEGIN {
26
BEGIN {
27
	require Exporter;
27
	require Exporter;
28
	@ISA = qw(Exporter);
28
	@ISA = qw(Exporter);
29
	@EXPORT =
29
	@EXPORT_OK =
30
		qw(get_jobs get_at_jobs get_at_job add_at_job remove_at_job);
30
		qw(get_jobs get_at_jobs get_at_job add_at_job remove_at_job);
31
}
31
}
32
32
(-)a/C4/Search.pm (-13 / +15 lines)
Lines 16-22 package C4::Search; Link Here
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
require Exporter;
20
use C4::Context;
19
use C4::Context;
21
use C4::Biblio;    # GetMarcFromKohaField, GetBiblioData
20
use C4::Biblio;    # GetMarcFromKohaField, GetBiblioData
22
use C4::Koha;      # getFacets
21
use C4::Koha;      # getFacets
Lines 37-43 use URI::Escape; Link Here
37
use Business::ISBN;
36
use Business::ISBN;
38
use MARC::Record;
37
use MARC::Record;
39
use MARC::Field;
38
use MARC::Field;
40
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
39
40
our (@ISA, @EXPORT_OK);
41
BEGIN {
42
    require Exporter;
43
    @ISA    = qw(Exporter);
44
    @EXPORT_OK = qw(
45
      &FindDuplicate
46
      &SimpleSearch
47
      &searchResults
48
      &getRecords
49
      &buildQuery
50
      &GetDistinctValues
51
      &enabled_staff_search_views
52
    );
53
}
41
54
42
=head1 NAME
55
=head1 NAME
43
56
Lines 55-71 This module provides searching functions for Koha's bibliographic databases Link Here
55
68
56
=cut
69
=cut
57
70
58
@ISA    = qw(Exporter);
59
@EXPORT = qw(
60
  &FindDuplicate
61
  &SimpleSearch
62
  &searchResults
63
  &getRecords
64
  &buildQuery
65
  &GetDistinctValues
66
  &enabled_staff_search_views
67
);
68
69
# make all your functions, whether exported or not;
71
# make all your functions, whether exported or not;
70
72
71
=head2 FindDuplicate
73
=head2 FindDuplicate
(-)a/C4/Serials.pm (-3 / +2 lines)
Lines 37-44 use Koha::Subscription::Histories; Link Here
37
use Koha::SharedContent;
37
use Koha::SharedContent;
38
use Scalar::Util qw( looks_like_number );
38
use Scalar::Util qw( looks_like_number );
39
39
40
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
41
42
# Define statuses
40
# Define statuses
43
use constant {
41
use constant {
44
    EXPECTED               => 1,
42
    EXPECTED               => 1,
Lines 61-70 use constant MISSING_STATUSES => ( Link Here
61
    MISSING_LOST
59
    MISSING_LOST
62
);
60
);
63
61
62
our (@ISA, @EXPORT_OK);
64
BEGIN {
63
BEGIN {
65
    require Exporter;
64
    require Exporter;
66
    @ISA    = qw(Exporter);
65
    @ISA    = qw(Exporter);
67
    @EXPORT = qw(
66
    @EXPORT_OK = qw(
68
      &NewSubscription    &ModSubscription    &DelSubscription
67
      &NewSubscription    &ModSubscription    &DelSubscription
69
      &GetSubscription    &CountSubscriptionFromBiblionumber      &GetSubscriptionsFromBiblionumber
68
      &GetSubscription    &CountSubscriptionFromBiblionumber      &GetSubscriptionsFromBiblionumber
70
      &SearchSubscriptions
69
      &SearchSubscriptions
(-)a/C4/ShelfBrowser.pm (-5 / +2 lines)
Lines 26-40 use C4::Koha; Link Here
26
use Koha::Biblios;
26
use Koha::Biblios;
27
use Koha::Libraries;
27
use Koha::Libraries;
28
28
29
use vars qw(@ISA @EXPORT @EXPORT_OK);
29
our (@ISA, @EXPORT_OK);
30
31
BEGIN {
30
BEGIN {
32
	require Exporter;
31
	require Exporter;
33
	@ISA    = qw(Exporter);
32
	@ISA    = qw(Exporter);
34
	@EXPORT = qw(
35
	    &GetNearbyItems
36
    );
37
    @EXPORT_OK = qw(
33
    @EXPORT_OK = qw(
34
	    &GetNearbyItems
38
    );
35
    );
39
}
36
}
40
37
(-)a/C4/Tags.pm (-3 / +1 lines)
Lines 29-36 use Module::Load::Conditional qw/check_install/; Link Here
29
use constant TAG_FIELDS => qw(tag_id borrowernumber biblionumber term language date_created);
29
use constant TAG_FIELDS => qw(tag_id borrowernumber biblionumber term language date_created);
30
use constant TAG_SELECT => "SELECT " . join(',', TAG_FIELDS) . "\n FROM   tags_all\n";
30
use constant TAG_SELECT => "SELECT " . join(',', TAG_FIELDS) . "\n FROM   tags_all\n";
31
31
32
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
32
our (@ISA, @EXPORT_OK);
33
34
BEGIN {
33
BEGIN {
35
	@ISA = qw(Exporter);
34
	@ISA = qw(Exporter);
36
    @EXPORT_OK = qw(
35
    @EXPORT_OK = qw(
Lines 48-54 BEGIN { Link Here
48
      &get_filters
47
      &get_filters
49
      stratify_tags
48
      stratify_tags
50
    );
49
    );
51
	# %EXPORT_TAGS = ();
52
    my $ext_dict = C4::Context->preference('TagsExternalDictionary');
50
    my $ext_dict = C4::Context->preference('TagsExternalDictionary');
53
    if ( $ext_dict && ! check_install( module => 'Lingua::Ispell' ) ) {
51
    if ( $ext_dict && ! check_install( module => 'Lingua::Ispell' ) ) {
54
        warn "Ignoring TagsExternalDictionary, because Lingua::Ispell is not installed.";
52
        warn "Ignoring TagsExternalDictionary, because Lingua::Ispell is not installed.";
(-)a/C4/TmplTokenType.pm (-15 / +16 lines)
Lines 20-27 package C4::TmplTokenType; Link Here
20
use Modern::Perl;
20
use Modern::Perl;
21
require Exporter;
21
require Exporter;
22
22
23
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
24
25
###############################################################################
23
###############################################################################
26
24
27
=head1 NAME
25
=head1 NAME
Lines 38-62 The predefined constants are Link Here
38
###############################################################################
36
###############################################################################
39
37
40
38
41
@ISA = qw(Exporter);
42
@EXPORT_OK = qw(
43
    &TEXT
44
    &TEXT_PARAMETRIZED
45
    &CDATA
46
    &TAG
47
    &DECL
48
    &PI
49
    &DIRECTIVE
50
    &COMMENT
51
    &UNKNOWN
52
);
53
54
###############################################################################
39
###############################################################################
55
40
56
use vars qw( $_text $_text_parametrized $_cdata
41
use vars qw( $_text $_text_parametrized $_cdata
57
    $_tag $_decl $_pi $_directive $_comment $_null $_unknown );
42
    $_tag $_decl $_pi $_directive $_comment $_null $_unknown );
58
43
44
our (@ISA, @EXPORT_OK);
59
BEGIN {
45
BEGIN {
46
47
    require Exporter;
48
    @ISA = qw(Exporter);
49
    @EXPORT_OK = qw(
50
        &TEXT
51
        &TEXT_PARAMETRIZED
52
        &CDATA
53
        &TAG
54
        &DECL
55
        &PI
56
        &DIRECTIVE
57
        &COMMENT
58
        &UNKNOWN
59
    );
60
60
    my $new = sub {
61
    my $new = sub {
61
	my $this = 'C4::TmplTokenType';#shift;
62
	my $this = 'C4::TmplTokenType';#shift;
62
	my $class = ref($this) || $this;
63
	my $class = ref($this) || $this;
(-)a/C4/XISBN.pm (-3 / +2 lines)
Lines 31-42 use Koha::Biblios; Link Here
31
use Koha::SearchEngine;
31
use Koha::SearchEngine;
32
use Koha::SearchEngine::Search;
32
use Koha::SearchEngine::Search;
33
33
34
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
34
our (@ISA, @EXPORT_OK);
35
36
BEGIN {
35
BEGIN {
37
	require Exporter;
36
	require Exporter;
38
	@ISA = qw(Exporter);
37
	@ISA = qw(Exporter);
39
	@EXPORT_OK = qw(
38
    @EXPORT_OK = qw(
40
		&get_xisbns
39
		&get_xisbns
41
	);
40
	);
42
}
41
}
(-)a/Koha/AuthUtils.pm (-3 / +6 lines)
Lines 27-36 use Koha::Exceptions::Password; Link Here
27
27
28
use C4::Context;
28
use C4::Context;
29
29
30
use base 'Exporter';
31
32
our @EXPORT_OK   = qw(hash_password get_script_name);
33
30
31
our (@ISA, @EXPORT_OK);
32
BEGIN {
33
    require Exporter;
34
    @ISA = qw(Exporter);
35
    @EXPORT_OK = qw(hash_password get_script_name);
36
};
34
=head1 NAME
37
=head1 NAME
35
38
36
Koha::AuthUtils - utility routines for authentication
39
Koha::AuthUtils - utility routines for authentication
(-)a/Koha/EDI.pm (-1 / +1 lines)
Lines 41-47 use Koha::Acquisition::Baskets; Link Here
41
use Koha::Acquisition::Booksellers;
41
use Koha::Acquisition::Booksellers;
42
42
43
our $VERSION = 1.1;
43
our $VERSION = 1.1;
44
our @EXPORT_OK =
44
push @EXPORT_OK,
45
  qw( process_quote process_invoice process_ordrsp create_edi_order get_edifact_ean );
45
  qw( process_quote process_invoice process_ordrsp create_edi_order get_edifact_ean );
46
46
47
sub create_edi_order {
47
sub create_edi_order {
(-)a/Koha/Item/Search/Field.pm (-9 / +13 lines)
Lines 1-15 Link Here
1
package Koha::Item::Search::Field;
1
package Koha::Item::Search::Field;
2
2
3
use Modern::Perl;
3
use Modern::Perl;
4
use base qw( Exporter );
4
5
5
our (@ISA, @EXPORT_OK);
6
our @EXPORT_OK = qw(
6
BEGIN {
7
    AddItemSearchField
7
    require Exporter
8
    ModItemSearchField
8
    @ISA = qw(Exporter);
9
    DelItemSearchField
9
    @EXPORT_OK, qw(
10
    GetItemSearchField
10
        AddItemSearchField
11
    GetItemSearchFields
11
        ModItemSearchField
12
);
12
        DelItemSearchField
13
        GetItemSearchField
14
        GetItemSearchFields
15
    );
16
};
13
17
14
use C4::Context;
18
use C4::Context;
15
19
(-)a/Koha/Patron/Password/Recovery.pm (-3 / +2 lines)
Lines 23-34 use C4::Letters; Link Here
23
use Crypt::Eksblowfish::Bcrypt qw(en_base64);
23
use Crypt::Eksblowfish::Bcrypt qw(en_base64);
24
use Koha::DateUtils;
24
use Koha::DateUtils;
25
25
26
use vars qw(@ISA @EXPORT);
26
our (@ISA, @EXPORT_OK);
27
28
BEGIN {
27
BEGIN {
29
    require Exporter;
28
    require Exporter;
30
    @ISA = qw(Exporter);
29
    @ISA = qw(Exporter);
31
    push @EXPORT, qw(
30
    @EXPORT_OK = qw(
32
      &ValidateBorrowernumber
31
      &ValidateBorrowernumber
33
      &SendPasswordRecoveryEmail
32
      &SendPasswordRecoveryEmail
34
      &GetValidLinkInfo
33
      &GetValidLinkInfo
(-)a/Koha/SimpleMARC.pm (-23 / +17 lines)
Lines 18-46 package Koha::SimpleMARC; Link Here
18
18
19
use Modern::Perl;
19
use Modern::Perl;
20
20
21
#use MARC::Record;
21
our (@ISA, @EXPORT_OK);
22
22
BEGIN {
23
require Exporter;
23
    require Exporter;
24
24
    our @ISA = qw(Exporter);
25
our @ISA = qw(Exporter);
25
26
our %EXPORT_TAGS = ( 'all' => [ qw(
26
    @EXPORT_OK = qw(
27
27
      read_field
28
) ] );
28
      add_field
29
29
      update_field
30
our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
30
      copy_field
31
31
      copy_and_replace_field
32
our @EXPORT = qw(
32
      move_field
33
  read_field
33
      delete_field
34
  add_field
34
      field_exists
35
  update_field
35
      field_equals
36
  copy_field
36
    );
37
  copy_and_replace_field
37
}
38
  move_field
39
  delete_field
40
  field_exists
41
  field_equals
42
);
43
44
38
45
our $debug = 0;
39
our $debug = 0;
46
40
(-)a/Koha/Util/FrameworkPlugin.pm (-8 lines)
Lines 22-35 package Koha::Util::FrameworkPlugin; Link Here
22
22
23
use Modern::Perl;
23
use Modern::Perl;
24
24
25
our ( @ISA, @EXPORT, @EXPORT_OK );
26
BEGIN {
27
    require Exporter;
28
    @ISA = qw( Exporter );
29
    @EXPORT = qw( );
30
    @EXPORT_OK = qw( wrapper date_entered );
31
}
32
33
=head1 NAME
25
=head1 NAME
34
26
35
Koha::Util::FrameworkPlugin - utility class with routines for framework plugins
27
Koha::Util::FrameworkPlugin - utility class with routines for framework plugins
(-)a/Koha/pdfformat/layout2pagesde.pm (-5 / +4 lines)
Lines 21-27 package Koha::pdfformat::layout2pagesde; Link Here
21
# along with Koha; if not, see <http://www.gnu.org/licenses>.
21
# along with Koha; if not, see <http://www.gnu.org/licenses>.
22
22
23
#you can use any PDF::API2 module, all you need to do is return the stringifyed pdf object from the printpdf sub.
23
#you can use any PDF::API2 module, all you need to do is return the stringifyed pdf object from the printpdf sub.
24
use vars qw(@ISA @EXPORT);
25
use MIME::Base64;
24
use MIME::Base64;
26
use Modern::Perl;
25
use Modern::Perl;
27
use utf8;
26
use utf8;
Lines 30-40 use Koha::Number::Price; Link Here
30
use Koha::DateUtils;
29
use Koha::DateUtils;
31
use Koha::Libraries;
30
use Koha::Libraries;
32
31
32
our (@ISA, @EXPORT_OK);
33
BEGIN {
33
BEGIN {
34
         use Exporter   ();
34
    require Exporter;
35
         our (@ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
35
    @ISA    = qw(Exporter);
36
	@ISA    = qw(Exporter);
36
    @EXPORT_OK = qw(printpdf);
37
	@EXPORT = qw(printpdf);
38
}
37
}
39
38
40
39
(-)a/misc/translator/TmplTokenizer.pm (-5 lines)
Lines 7-14 use C4::TTParser; Link Here
7
use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic );
7
use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic );
8
require Exporter;
8
require Exporter;
9
9
10
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
11
12
###############################################################################
10
###############################################################################
13
11
14
=head1 NAME
12
=head1 NAME
Lines 24-32 A wrapper for the functionality found in TTParser to allow an easier transition Link Here
24
###############################################################################
22
###############################################################################
25
23
26
24
27
@ISA = qw(Exporter);
28
@EXPORT_OK = qw();
29
30
use vars qw( $pedantic_attribute_error_in_nonpedantic_mode_p );
25
use vars qw( $pedantic_attribute_error_in_nonpedantic_mode_p );
31
use vars qw( $pedantic_tmpl_var_use_in_nonpedantic_mode_p );
26
use vars qw( $pedantic_tmpl_var_use_in_nonpedantic_mode_p );
32
use vars qw( $pedantic_error_markup_in_pcdata_p );
27
use vars qw( $pedantic_error_markup_in_pcdata_p );
(-)a/misc/translator/VerboseWarnings.pm (-17 / +17 lines)
Lines 1-9 Link Here
1
package VerboseWarnings;
1
package VerboseWarnings;
2
2
3
use Modern::Perl;
3
use Modern::Perl;
4
require Exporter;
5
6
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
7
4
8
###############################################################################
5
###############################################################################
9
6
Lines 20-39 verbose warnings. Link Here
20
17
21
###############################################################################
18
###############################################################################
22
19
23
20
our (@ISA, @EXPORT_OK);
24
@ISA = qw(Exporter);
21
BEGIN {
25
@EXPORT_OK = qw(
22
    require Exporter;
26
    &pedantic_p
23
    @ISA = qw(Exporter);
27
    &warn_additional
24
    @EXPORT_OK = qw(
28
    &warn_normal
25
        &pedantic_p
29
    &warn_pedantic
26
        &warn_additional
30
    &error_additional
27
        &warn_normal
31
    &error_normal
28
        &warn_pedantic
32
);
29
        &error_additional
33
%EXPORT_TAGS = (
30
        &error_normal
34
    'warn' => [ 'warn_additional',  'warn_normal',  'warn_pedantic' ],
31
    );
35
    'die'  => [ 'error_additional', 'error_normal' ],
32
    %EXPORT_TAGS = (
36
);
33
        'warn' => [ 'warn_additional',  'warn_normal',  'warn_pedantic' ],
34
        'die'  => [ 'error_additional', 'error_normal' ],
35
    );
36
}
37
37
38
###############################################################################
38
###############################################################################
39
39
(-)a/t/db_dependent/Members/IssueSlip.t (-3 / +2 lines)
Lines 25-32 use Test::MockTime qw( set_fixed_time ); Link Here
25
use t::lib::TestBuilder;
25
use t::lib::TestBuilder;
26
26
27
use C4::Circulation;
27
use C4::Circulation;
28
use C4::Biblio;
28
use C4::Biblio qw( AddBiblio );
29
use C4::Items;
29
use C4::Items qw( AddItem );
30
use C4::Members;
30
use C4::Members;
31
31
32
use Koha::DateUtils qw( dt_from_string output_pref );
32
use Koha::DateUtils qw( dt_from_string output_pref );
33
- 

Return to bug 17600