From b85d48d39fdfc000658f9d9b5e49471e5243b9a0 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 2 Apr 2021 09:09:25 +0000
Subject: [PATCH] Bug 26302: Use resultsMaxItemsUnavailable in stylesheet
Content-Type: text/plain; charset=utf-8

We start here with Checked out until On hold.
Not sure if we should do exactly the same for the remaining
not for loan categories.
---
 .../en/xslt/MARC21slim2OPACResults.xsl        | 115 ++++++++++--------
 1 file changed, 67 insertions(+), 48 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
index b496ca9f53..0cf3f62a51 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
@@ -40,6 +40,7 @@
     <xsl:variable name="OPACTrackClicks" select="marc:sysprefs/marc:syspref[@name='TrackClicks']"/>
     <xsl:variable name="BiblioDefaultView" select="marc:sysprefs/marc:syspref[@name='BiblioDefaultView']"/>
     <xsl:variable name="resultsMaxItems" select="marc:sysprefs/marc:syspref[@name='resultsMaxItems']"/>
+    <xsl:variable name="resultsMaxItemsUnavailable" select="marc:sysprefs/marc:syspref[@name='resultsMaxItemsUnavailable']"/>
         <xsl:variable name="leader" select="marc:leader"/>
         <xsl:variable name="leader6" select="substring($leader,7,1)"/>
         <xsl:variable name="leader7" select="substring($leader,8,1)"/>
@@ -1415,55 +1416,50 @@
                         </xsl:for-each>
 
                         <!-- Followed by other statuses -->
-                        <xsl:if test="count(key('item-by-status', 'Checked out'))>0">
-                            <span class="unavailable">
-                                <xsl:text>Checked out (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Checked out'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="count(key('item-by-status', 'Withdrawn'))>0">
-                            <span class="unavailable">
-                                <xsl:text>Withdrawn (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Withdrawn'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="$hidelostitems='0' and count(key('item-by-status', 'Lost'))>0">
-                            <span class="unavailable">
-                                <xsl:text>Lost (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Lost'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="count(key('item-by-status', 'Damaged'))>0">
-                            <span class="unavailable">
-                                <xsl:text>Damaged (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Damaged'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="count(key('item-by-status', 'Pending hold'))>0">
-                            <span class="unavailable">
-                                <xsl:text>Pending hold (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Pending hold'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="count(key('item-by-status', 'In transit'))>0">
-                            <span class="unavailable">
-                                <xsl:text>In transit (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'In transit'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
-                        </xsl:if>
-                        <xsl:if test="count(key('item-by-status', 'Waiting'))>0">
-                            <span class="unavailable">
-                                <xsl:text>On hold (</xsl:text>
-                                <xsl:value-of select="count(key('item-by-status', 'Waiting'))"/>
-                                <xsl:text>). </xsl:text>
-                            </span>
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">Checked out</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'Checked out')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">Withdrawn</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'Withdrawn')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
+                        <xsl:if test="$hidelostitems='0'">
+                            <xsl:call-template name="listCallNumbers">
+                                <xsl:with-param name="status_text">Lost</xsl:with-param>
+                                <xsl:with-param name="items" select="key('item-by-status', 'Lost')"/>
+                                <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                            </xsl:call-template>
                         </xsl:if>
+
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">Damaged</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'Damaged')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">Pending hold</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'Pending hold')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">In transit</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'In transit')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
+                        <xsl:call-template name="listCallNumbers">
+                            <xsl:with-param name="status_text">On hold</xsl:with-param>
+                            <xsl:with-param name="items" select="key('item-by-status', 'Waiting')"/>
+                            <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
+                        </xsl:call-template>
+
                     </span>
                 </xsl:when>
             </xsl:choose>
@@ -1623,4 +1619,27 @@
         </xsl:if>
     </xsl:template>
 
+    <xsl:template name="listCallNumbers">
+        <xsl:param name="items"/>
+        <xsl:param name="max"/>
+        <xsl:param name="status_text"/>
+        <xsl:if test="count($items)>0">
+            <span class="unavailable">
+                <xsl:value-of select="$status_text"/>
+                <xsl:text> (</xsl:text>
+                <xsl:value-of select="count($items)"/>
+                <xsl:text>)</xsl:text>
+                <xsl:if test="$max>0">
+                    <xsl:text> [ </xsl:text>
+                    <xsl:for-each select="$items[position() &lt;= $max]">
+                        <xsl:value-of select="items:itemcallnumber"/><xsl:if test="position()!=last()"><xsl:text>, </xsl:text></xsl:if>
+                    </xsl:for-each>
+                    <xsl:if test="count($items)>$max"><xsl:text>, ..</xsl:text></xsl:if>
+                    <xsl:text> ]</xsl:text>
+                </xsl:if>
+                <xsl:text>. </xsl:text>
+            </span>
+        </xsl:if>
+    </xsl:template>
+
 </xsl:stylesheet>
-- 
2.20.1