From 7b58d1d27848a67fb0caa055bba3574fcb058385 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Thu, 8 Jul 2021 20:57:58 +0000 Subject: [PATCH] Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well --- admin/columns_settings.yml | 2 ++ circ/overdue.pl | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 ++ 3 files changed, 6 insertions(+) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index b6eee4fb28..6c21a4efc7 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -1319,6 +1319,8 @@ modules: - columnname: holding_library is_hidden: 1 + - + columnname: shelving_location - columnname: barcode - diff --git a/circ/overdue.pl b/circ/overdue.pl index c402588d19..9852209c15 100755 --- a/circ/overdue.pl +++ b/circ/overdue.pl @@ -232,6 +232,7 @@ if ($noreport) { items.barcode, items.homebranch, items.holdingbranch, + items.location, biblio.title, biblio.author, biblio.biblionumber, @@ -324,6 +325,7 @@ if ($noreport) { author => $data->{author}, homebranchcode => $data->{homebranch}, holdingbranchcode => $data->{holdingbranch}, + location => $data->{location}, itemcallnumber => $data->{itemcallnumber}, replacementprice => $data->{replacementprice}, itemnotes_nonpublic => $data->{itemnotes_nonpublic}, diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt index 3723357b3a..febd0d66c9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt @@ -86,6 +86,7 @@ Title Home library Holding library + Shelving location Barcode Call number Item type @@ -109,6 +110,7 @@ [% INCLUDE 'biblio-title.inc' biblio=overdueloo link = 1 %] [% IF ( overdueloo.author ) %], by [% overdueloo.author | html %][% END %][% IF ( overdueloo.enumchron ) %], [% overdueloo.enumchron | html %][% END %] [% Branches.GetName( overdueloo.homebranchcode ) | html %] [% Branches.GetName( overdueloo.holdingbranchcode ) | html %] + [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => overdueloo.location ) | html %] [% overdueloo.barcode | html %] [% overdueloo.itemcallnumber | html %] [% ItemTypes.GetDescription( overdueloo.itemtype ) | html %] -- 2.20.1