From 95ee9727a61450cfe83836bae516a6e40ebcae90 Mon Sep 17 00:00:00 2001
From: Henry Bolshaw <bolshawh@parliament.uk>
Date: Thu, 15 Jul 2021 22:32:40 +0000
Subject: [PATCH] Bug 28142: Accessibility: OPAC cart/basket checkboxes are not
 labelled

This patch adds labels to the checkboxes on the "Your cart" page to
improve accessibility for users of screen readers. The labels are
hidden from display because the item titles provide enough visual
context.

Test Plan:

1. Go to the OPAC
2. Search for some items and add them to your cart
3. Inspect the page html and confirm the checkboxes are not labelled
4. Select the "More Details" page and confirm these labels are missing too
5. Apply the patch
6. Inspect the checkboxes on the "Brief display" and "more details" views
7. Confirm that the checkboxes have meaningful labels and that the visual
display of the pages has not changed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt    | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
index a371bb88bd..3cfa0db68a 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
@@ -82,6 +82,12 @@
                         [% IF ( verbose ) %]
                             <form action="opac-basket.pl" method="get" name="bookbag_form" id="bookbag_form">
                                 [% FOREACH BIBLIO_RESULT IN BIBLIO_RESULTS %]
+                                    [% IF BIBLIO_RESULT.title %]
+                                        [% check_title = BIBLIO_RESULT.title %]
+                                    [% ELSE %]
+                                        [% check_title = BIBLIO_RESULT.biblionumber %]
+                                    [% END %]
+                                    <label for="bib[% BIBLIO_RESULT.biblionumber | html %]" class="sr-only">[% check_title | html %]</label>
                                     <h2>
                                                 <input type="checkbox" class="cb" value="[% BIBLIO_RESULT.biblionumber | html %]" name="bib[% BIBLIO_RESULT.biblionumber | html %]" id="bib[% BIBLIO_RESULT.biblionumber | html %]">
                                                 [% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT %]
@@ -271,6 +277,12 @@
                                     [% FOREACH BIBLIO_RESULT IN BIBLIO_RESULTS %]
                                         <tr>
                                                 <td class="noprint selectcol">
+                                                    [% IF BIBLIO_RESULT.title %]
+                                                        [% check_title = BIBLIO_RESULT.title %]
+                                                    [% ELSE %]
+                                                        [% check_title = BIBLIO_RESULT.biblionumber %]
+                                                    [% END %]
+                                    <label for="bib[% BIBLIO_RESULT.biblionumber | html %]" class="sr-only">[% check_title | html %]</label>
                                                 <input type="checkbox" class="cb" value="[% BIBLIO_RESULT.biblionumber | html %]" name="bib[% BIBLIO_RESULT.biblionumber | html %]" id="bib[% BIBLIO_RESULT.biblionumber | html %]">
                                                 </td>
                                             <td>
-- 
2.20.1