From ea792fef0b69ed118b290003edeb19a36de771b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Fri, 28 May 2021 13:57:53 +0300 Subject: [PATCH] Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level We need to pass undef itemnumber to build_object() to actually have a hold without an item tied to it. Otherwise build_object() will create automatically an item for us (thus making it an item-level hold) To test: $ prove t/db_dependent/Koha/Item.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize --- t/db_dependent/Koha/Item.t | 1 + 1 file changed, 1 insertion(+) diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t index 2080a93ad2a..dc37bc57e05 100755 --- a/t/db_dependent/Koha/Item.t +++ b/t/db_dependent/Koha/Item.t @@ -927,6 +927,7 @@ subtest 'move_to_biblio() tests' => sub { class => 'Koha::Holds', value => { biblionumber => $source_biblionumber, + itemnumber => undef, }, }); my $item_level_hold1 = $builder->build_object({ -- 2.20.1