From b3c0748917144d94cacf0fd76ba5123b9ffc4c24 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 21 Jun 2021 18:32:50 +0100 Subject: [PATCH] Bug 22435: (QA follow-up) More test updates Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Accounts.t | 8 ++++---- t/db_dependent/Circulation.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t index 9aa5ca9604..c1ad715168 100755 --- a/t/db_dependent/Accounts.t +++ b/t/db_dependent/Accounts.t @@ -950,7 +950,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { { credit_id => $credit->id, debit_id => $debit->id, - type => 'Payment', + type => 'APPLY', amount => 0 } )->store(); @@ -983,7 +983,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { { credit_id => $credit->id, debit_id => $debit->id, - type => 'Payment', + type => 'APPLY', amount => 0 } )->store(); @@ -1017,7 +1017,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { { credit_id => $credit->id, debit_id => $debit->id, - type => 'Payment', + type => 'APPLY', amount => 0 } )->store(); @@ -1084,7 +1084,7 @@ subtest "Koha::Account::Offset credit & debit tests" => sub { { credit_id => undef, debit_id => undef, - type => 'Payment', + type => 'CREATE', amount => 0, } )->store(); diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 77d3eaa2bc..e054c74ab5 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -3411,7 +3411,7 @@ subtest '_FixOverduesOnReturn' => sub { C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' ); $accountline->_result()->discard_changes(); - $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next(); + $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'CREATE' })->next(); is( $offset, undef, "No offset created when trying to forgive fine with no outstanding balance" ); isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )'); is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )'); -- 2.20.1