Bugzilla – Attachment 123015 Details for
Bug 28731
Subroutines not explicitly imported in reports svc (opac and staff)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28731: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint
Bug-28731-bug-17600-follow-up-Import-necessary-sub.patch (text/plain), 1.38 KB, created by
Jonathan Druart
on 2021-07-21 15:04:32 UTC
(
hide
)
Description:
Bug 28731: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-07-21 15:04:32 UTC
Size:
1.38 KB
patch
obsolete
>From 3748efc8abbe8ff62bfa263fbfc25c7f333aae96 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 21 Jul 2021 14:55:01 +0000 >Subject: [PATCH] Bug 28731: (bug 17600 follow-up) Import necessary subroutines > in reports svc endpoint > >TO test: > 1 - Write a report > 2 - Click the svc link in the saved reports list > 3 - ISE > 4 - Make report public > 5 - Click the svc link in saved reports list > 6 - ISE > 7 - Apply patch > 8 - Comfirm opac/public link works > 9 - Make report not public >10 - Confirm the internal svc link works > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/svc/report | 2 +- > svc/report | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/svc/report b/opac/svc/report >index 1e585cf5068..5aad6fe3bf4 100755 >--- a/opac/svc/report >+++ b/opac/svc/report >@@ -24,7 +24,7 @@ > use Modern::Perl; > > use C4::Output qw(output_with_http_headers); >-use C4::Reports::Guided; >+use C4::Reports::Guided qw( execute_query ); > use Koha::Reports; > use JSON; > use CGI qw ( -utf8 ); >diff --git a/svc/report b/svc/report >index 18b0f2bd4b8..cf9765fc262 100755 >--- a/svc/report >+++ b/svc/report >@@ -20,8 +20,8 @@ > > use Modern::Perl; > >-use C4::Auth; >-use C4::Reports::Guided; >+use C4::Auth qw( get_template_and_user ); >+use C4::Reports::Guided qw( execute_query ); > use Koha::Reports; > use JSON; > use CGI qw ( -utf8 ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28731
:
123014
| 123015