Bugzilla – Attachment 123097 Details for
Bug 28718
Can't delete multiple news items at once
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28718: handle multiple deletions from news
Bug-28718-handle-multiple-deletions-from-news.patch (text/plain), 1.06 KB, created by
Joonas Kylmälä
on 2021-07-23 11:00:09 UTC
(
hide
)
Description:
Bug 28718: handle multiple deletions from news
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-07-23 11:00:09 UTC
Size:
1.06 KB
patch
obsolete
>From caf250dbc97ed0ca9e510556a9f4206e1b916e44 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 16 Jul 2021 14:44:10 +0000 >Subject: [PATCH] Bug 28718: handle multiple deletions from news >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. have multiple news >2. check several of them and and click 'Delete selected' >3. see ugly error >4. apply patch >5. try again >6. no error > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > tools/koha-news.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/koha-news.pl b/tools/koha-news.pl >index cfc8066104..ef615a4e0d 100755 >--- a/tools/koha-news.pl >+++ b/tools/koha-news.pl >@@ -138,7 +138,7 @@ elsif ( $op eq 'edit' ) { > } > elsif ( $op eq 'del' ) { > my @ids = $cgi->multi_param('ids'); >- Koha::News->search({ idnew => @ids })->delete; >+ Koha::News->search({ idnew => \@ids })->delete; > print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl"); > } > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28718
:
122898
|
122940
| 123097