From 662445eca36b50dd30f3f72c91803cf6f81d2bdb Mon Sep 17 00:00:00 2001 From: David Gustafsson Date: Fri, 23 Jul 2021 16:37:22 +0200 Subject: [PATCH] Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen --- admin/preferences.pl | 4 ++++ .../prog/en/modules/admin/preferences/cataloguing.pref | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/admin/preferences.pl b/admin/preferences.pl index 49d06ad996..f31a533b15 100755 --- a/admin/preferences.pl +++ b/admin/preferences.pl @@ -28,6 +28,7 @@ use C4::ClassSource qw( GetClassSources GetClassSource ); use C4::Output qw( output_html_with_http_headers ); use C4::Templates; use Koha::Acquisition::Currencies; +use Koha::MarcModificationTemplates; use IO::File; use YAML::XS; use Encode; @@ -103,6 +104,9 @@ sub _get_chunk { } elsif ( $options{choices} eq 'patron-categories' ) { $options{choices} = { map { $_->categorycode => $_->description } Koha::Patron::Categories->search }; $add_blank = 1; + } elsif ( $options{choices} eq 'marc-modification-templates' ) { + $options{choices} = { map { $_->template_id => $_->name } Koha::MarcModificationTemplates->search }; + $add_blank = 1; } else { die 'Unrecognized source of preference values: ' . $options{'choices'}; } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref index 550bf5569f..d236f712fd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref @@ -161,7 +161,7 @@ Cataloging: - - Apply the MARC modification template with name - pref: SaveBiblioMarcModificationTemplate - class: short + class: marc-modification-templates - on records saved using the staff client simple MARC editor, advanced editor or HTTP API. Display: - -- 2.20.1