From 01513537c7f36073c582d7f17e62f4e596d95712 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 23 Jul 2021 13:53:44 +0000 Subject: [PATCH] Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! Signed-off-by: David Nind --- svc/cataloguing/framework | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/svc/cataloguing/framework b/svc/cataloguing/framework index ec9108f222..f7456128ad 100755 --- a/svc/cataloguing/framework +++ b/svc/cataloguing/framework @@ -15,7 +15,7 @@ my ( $query, $response ) = C4::Service->init( editcatalogue => 'edit_catalogue' my $frameworkcode = $query->param( 'frameworkcode' ) // ''; -my $tagslib = GetMarcStructure( 1, $frameworkcode ); +my $tagslib = C4::Biblio::GetMarcStructure( 1, $frameworkcode ); my @tags; @@ -42,7 +42,7 @@ $authorised_values->{itemtypes} = [ $schema->resultset( "Itemtype" )->search( un result_class => 'DBIx::Class::ResultClass::HashRefInflator' } ) ]; -my $class_sources = GetClassSources(); +my $class_sources = C4::ClassSource::GetClassSources(); my $default_source = C4::Context->preference("DefaultClassificationSource"); -- 2.20.1