Bugzilla – Attachment 12320 Details for
Bug 8772
Uninitialized variable triggers error log entry in smart_rules.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl
SIGNED-OFF-Bug-8772---Uninitialized-variable-trigg.patch (text/plain), 1.36 KB, created by
Marc Véron
on 2012-09-18 18:06:02 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-09-18 18:06:02 UTC
Size:
1.36 KB
patch
obsolete
>From c5ccb4058454485e723c475e4a3f8585aa2e2f8e Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 19 Sep 2012 00:05:24 +0800 >Subject: [PATCH] [SIGNED-OFF] Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl >Content-Type: text/plain; charset="utf-8" > >Changed declartion from: > my $op = $input->param('op'); >to > my $op = $input->param('op') || q{}; >in order to give an empty string default preventing error >logs from filling needlessly. > >Signed-off-by: Marc Veron <veron@veron.ch> > >The patch removes warnings like: >Use of uninitialized value $op in string eq at... > >However there is one more warning, but it is not related to $op (addressed by this patch): >smart-rules.pl: Use of uninitialized value in string ne at .../admin/smart-rules.pl line 388. >--- > admin/smart-rules.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index f45ea43..c221d71 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -44,7 +44,7 @@ my ($template, $loggedinuser, $cookie) > > my $type=$input->param('type'); > my $branch = $input->param('branch') || ( C4::Branch::onlymine() ? ( C4::Branch::mybranch() || '*' ) : '*' ); >-my $op = $input->param('op'); >+my $op = $input->param('op') || q{}; > > if ($op eq 'delete') { > my $itemtype = $input->param('itemtype'); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8772
:
12318
| 12320