From 23ad09a20e2e0183eab420e4c16fce1a8fbe2086 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 28 Jul 2021 12:24:14 +0200 Subject: [PATCH] Bug 28632: Prevent api/v1/patrons.t to fail on dates comparison # Failed test 'Returned patron from update matches expected' # at t/db_dependent/api/v1/patrons.t line 537. # Structures begin differing at: # $got->{updated_on} = '2021-07-27T13:33:53+00:00' # $expected->{updated_on} = '2021-07-27T13:33:52+00:00' # Looks like you failed 1 test of 42. --- t/db_dependent/api/v1/patrons.t | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/api/v1/patrons.t b/t/db_dependent/api/v1/patrons.t index 441120f23a5..5b1e33119b8 100755 --- a/t/db_dependent/api/v1/patrons.t +++ b/t/db_dependent/api/v1/patrons.t @@ -24,6 +24,7 @@ use Test::Warn; use t::lib::TestBuilder; use t::lib::Mocks; +use t::lib::Dates; use C4::Auth; use Koha::Database; @@ -534,7 +535,13 @@ subtest 'update() tests' => sub { $newpatron->{patron_id} = $unauthorized_patron->to_api->{patron_id}; $newpatron->{restricted} = $unauthorized_patron->to_api->{restricted}; $newpatron->{anonymized} = $unauthorized_patron->to_api->{anonymized}; - is_deeply($result->tx->res->json, $newpatron, 'Returned patron from update matches expected'); + + my $got = $result->tx->res->json; + my $updated_on_got = delete $got->{updated_on}; + my $updated_on_expected = delete $newpatron->{updated_on}; + is_deeply($got, $newpatron, 'Returned patron from update matches expected'); + t::lib::Dates::compare( $updated_on_got, $updated_on_expected, 'updated_on values matched' ); + is(Koha::Patrons->find( $patron_2->id )->cardnumber, $newpatron->{ cardnumber }, 'Patron is really updated!'); -- 2.20.1