From ecb6de396939aa29bdc165c1971aa83dedaf3a3c Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 6 Aug 2021 11:19:12 +0000 Subject: [PATCH] Bug 7703: Don't block bulk hold action on search results if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard --- .../prog/en/modules/reserve/request.tt | 20 ++++++++++--------- .../intranet-tmpl/prog/js/pages/results.js | 9 --------- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 5a8545c612..1b4f162666 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -831,16 +831,18 @@ [% END %] - + + [% FOREACH pickup_location IN biblioloo.pickup_locations %] + + [% END %] + [% END %] - [% END # /FOREACH biblioloo %] diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js index 785817c097..c1bd815cea 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js @@ -338,19 +338,10 @@ function placeHold () { return false; } var bibs = ""; - var badBibs = false; $(checkedItems).each(function() { var bib = $(this).val(); - if ($("#reserve_" + bib).size() == 0) { - alert( __("One or more selected items cannot be placed on hold.") ); - badBibs = true; - return false; - } bibs += bib + "/"; }); - if (badBibs) { - return false; - } $("#hold_form_biblios").val(bibs); $("#hold_form").submit(); return false; -- 2.20.1