Bugzilla – Attachment 123727 Details for
Bug 28727
"Edit item" button on moredetail should be enabled with edit_items permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28727: (QA follow-up) Simplify permission check
Bug-28727-QA-follow-up-Simplify-permission-check.patch (text/plain), 1.80 KB, created by
Katrin Fischer
on 2021-08-10 23:07:25 UTC
(
hide
)
Description:
Bug 28727: (QA follow-up) Simplify permission check
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-08-10 23:07:25 UTC
Size:
1.80 KB
patch
obsolete
>From c40ee95b69055ea977024b9aaaba668bbd0ffb7d Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 11 Aug 2021 01:04:49 +0200 >Subject: [PATCH] Bug 28727: (QA follow-up) Simplify permission check > >There was another permission check for edit_items directly below, >so instead of changing them to both be edit_items, I think we >can now remove one. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 802c38bb8c..2cb6b3b8c0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -89,11 +89,11 @@ > <div class="listgroup"> > <h3 id="item[% ITEM_DAT.itemnumber | html %]">Barcode [% ITEM_DAT.barcode | html %] [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]</h3> > >- <h4>Item information [% IF ( CAN_user_editcatalogue_edit_items ) %][% UNLESS ( ITEM_DAT.nomod ) %] >+ <h4>Item information [% UNLESS ( ITEM_DAT.nomod ) %] > [% IF ( CAN_user_editcatalogue_edit_items ) %] > <a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% ITEM_DAT.biblionumber | uri %]&itemnumber=[% ITEM_DAT.itemnumber | uri %]"><i class="fa fa-pencil"></i> Edit item</a> > [% END %] >- [% END %][% END %]</h4> >+ [% END %]</h4> > <div class="rows"> > <ol class="bibliodetails"> > <li><span class="label">Home library:</span> [% Branches.GetName( ITEM_DAT.homebranch ) | html %] </li> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28727
:
122992
|
123209
|
123726
| 123727