Bugzilla – Attachment 123802 Details for
Bug 28454
Add Koha version number to database schema link in reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28454: (follow-up) Add schema version to link on reports home page
Bug-28454-follow-up-Add-schema-version-to-link-on-.patch (text/plain), 2.36 KB, created by
Owen Leonard
on 2021-08-11 19:33:07 UTC
(
hide
)
Description:
Bug 28454: (follow-up) Add schema version to link on reports home page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-08-11 19:33:07 UTC
Size:
2.36 KB
patch
obsolete
>From 58dc35165a517be7dede2ea37e8c2128afdf9d51 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 11 Aug 2021 19:18:32 +0000 >Subject: [PATCH] Bug 28454: (follow-up) Add schema version to link on reports > home page > >This patch makes the same changes to the script and template for the >reports home page. >--- > .../prog/en/modules/reports/reports-home.tt | 2 +- > reports/reports-home.pl | 10 ++++++---- > 2 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >index b3ee4d5ba8..30465784d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >@@ -93,7 +93,7 @@ > <li><a href="/cgi-bin/koha/reports/orders_by_fund.pl">Orders by fund</a></li> > <li><a href="/cgi-bin/koha/reports/manager.pl?report_name=itemtypes">Catalog by item type</a></li> > <li><a href="/cgi-bin/koha/reports/issues_avg_stats.pl">Average loan time</a></li> >- <li><a href="http://schema.koha-community.org/" target="blank">Koha database schema</a></li> >+ <li><a href="http://schema.koha-community.org/[% schema_version | uri %]" target="blank">Koha database schema</a></li> > <li><a href="http://wiki.koha-community.org/wiki/SQL_Reports_Library" target="blank">Koha reports library</a></li> > </ul></div> > </div> >diff --git a/reports/reports-home.pl b/reports/reports-home.pl >index 71aaa87e83..0511286634 100755 >--- a/reports/reports-home.pl >+++ b/reports/reports-home.pl >@@ -32,8 +32,10 @@ my ($template, $loggedinuser, $cookie) > type => "intranet", > flagsrequired => {reports => '*'}, > }); >-$template->param(intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"), >- intranetstylesheet => C4::Context->preference("intranetstylesheet"), >- IntranetNav => C4::Context->preference("IntranetNav"), >- ); >+ >+my $version_string = Koha::version(); >+my ( $major, $minor, $maintenance, $development ) = split( '\.', $version_string ); >+my $schema_version = ( $development ne '000' ) ? "" : $major . "_" . $minor; >+$template->param( 'schema_version' => $schema_version ); >+ > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28454
:
121429
|
121491
|
123801
|
123802
|
123917
|
123918
|
124084
|
125073
|
125074
|
125316
|
125317