From cea63dde05cdf7f9c52b2c8ab673258084fe5039 Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Thu, 20 Sep 2012 07:39:16 -0400 Subject: [PATCH] Bug 8726 follow-up: fix perlcritic issues --- Koha/SuggestionEngine/Base.pm | 48 ++----------------------- Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 20 +++++++++- Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 20 +++++++++- Koha/SuggestionEngine/Plugin/Null.pm | 20 +++++++++- 4 files changed, 57 insertions(+), 51 deletions(-) diff --git a/Koha/SuggestionEngine/Base.pm b/Koha/SuggestionEngine/Base.pm index 5c52e2b..9565a7e 100644 --- a/Koha/SuggestionEngine/Base.pm +++ b/Koha/SuggestionEngine/Base.pm @@ -34,9 +34,9 @@ B - get suggestions for the search described in $param->{'search'}, and return them in a hashref with the suggestions as keys and relevance as values. -The following variables must be defined in each filter: - our $NAME ='Filter'; - our $VERSION = '1.0'; +B - return a string with the name of the plugin. + +B - return a string with the version of the plugin. These methods may be overriden: @@ -123,46 +123,4 @@ sub get_suggestions { return; } -=head2 NAME - - my $name = $plugin->NAME; - -Getter function for plugin names. - -=cut - -sub NAME { - my $self = shift; - my $package = ref $self || $self; - return eval '$' . $package . '::NAME'; -} - -=head2 VERSION - - my $version = $plugin->VERSION; - -Getter function for plugin versions. - -=cut - -sub VERSION { - my $self = shift; - my $package = ref $self || $self; - return eval '$' . $package . '::VERSION'; -} - -=head2 DESCRIPTION - - my $description = $plugin->DESCRIPTION; - -Getter function for plugin descriptions. - -=cut - -sub DESCRIPTION { - my $self = shift; - my $package = ref $self || $self; - return eval '$' . $package . '::DESCRIPTION'; -} - 1; diff --git a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm index 54a7248..cb4eefc 100644 --- a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm +++ b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm @@ -35,8 +35,24 @@ use warnings; use Carp; use base qw(Koha::SuggestionEngine::Base); -our $NAME = 'AuthorityFile'; -our $VERSION = '1.0'; + +=head2 NAME + my $name = $plugin->NAME; + +=cut + +sub NAME { + return 'AuthorityFile'; +} + +=head2 VERSION + my $version = $plugin->VERSION; + +=cut + +sub VERSION { + return '1.1'; +} =head2 get_suggestions diff --git a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm index a380261..3874ce9 100644 --- a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm +++ b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm @@ -37,8 +37,24 @@ use Carp; use C4::Templates qw(gettemplate); # This is necessary for translatability use base qw(Koha::SuggestionEngine::Base); -our $NAME = 'ExplodedTerms'; -our $VERSION = '1.0'; + +=head2 NAME + my $name = $plugin->NAME; + +=cut + +sub NAME { + return 'ExplodedTerms'; +} + +=head2 VERSION + my $version = $plugin->VERSION; + +=cut + +sub VERSION { + return '1.0'; +} =head2 get_suggestions diff --git a/Koha/SuggestionEngine/Plugin/Null.pm b/Koha/SuggestionEngine/Plugin/Null.pm index 307e035..a665661 100644 --- a/Koha/SuggestionEngine/Plugin/Null.pm +++ b/Koha/SuggestionEngine/Plugin/Null.pm @@ -36,8 +36,24 @@ use warnings; use Carp; use base qw(Koha::SuggestionEngine::Base); -our $NAME = 'Null'; -our $VERSION = '1.0'; + +=head2 NAME + my $name = $plugin->NAME; + +=cut + +sub NAME { + return 'Null'; +} + +=head2 VERSION + my $version = $plugin->VERSION; + +=cut + +sub VERSION { + return '1.1'; +} =head2 get_suggestions -- 1.7.2.5