Bugzilla – Attachment 123822 Details for
Bug 28839
Better texts in stage MARC for import
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28839: Better texts in stage MARC for import
Bug-28839-Better-texts-in-stage-MARC-for-import.patch (text/plain), 3.51 KB, created by
Fridolin Somers
on 2021-08-13 08:29:47 UTC
(
hide
)
Description:
Bug 28839: Better texts in stage MARC for import
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2021-08-13 08:29:47 UTC
Size:
3.51 KB
patch
obsolete
>From 52da9913c8e53dc984a8dfaa334ccb2a5018d7c8 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 10 Aug 2021 11:47:26 -1000 >Subject: [PATCH] Bug 28839: Better texts in stage MARC for import > >Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. >Its form contains texts in legends, labels, hints. > >I feel like : >Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. >Legend are sometimes contains redundant text, like "Stage records into the reservoir". >Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. > >Also lengends should be driving the user, that is why optional parts >contains a legend with "?". > >Test plan : >Compare texts in page without and with patch > >Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> >--- > .../prog/en/modules/tools/stage-marc-import.tt | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >index 4cd9e4b456..a12cfdb6ce 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >@@ -97,11 +97,11 @@ > </ul> > <form method="post" action="[% SCRIPT_NAME | html %]" id="uploadfile" enctype="multipart/form-data"> > <fieldset class="rows" id="uploadform"> >-<legend>Stage records into the reservoir</legend> >+<legend>Upload a file to stage</legend> > <ol> > <li> > <div id="fileuploadform"> >- <label for="fileToUpload">Select the file to stage: </label> >+ <label for="fileToUpload">File: </label> > <input type="file" id="fileToUpload" name="fileToUpload" /> > </div> </li> > </ol> >@@ -122,10 +122,10 @@ > </form> > > <fieldset class="rows" id="profile_fieldset"> >- <legend>Profile settings</legend> >+ <legend>Pre-fill values with profile?</legend> > <ol> > <li> >- <label for="profile">Pre-fill values with profile</label> >+ <label for="profile">Profile: </label> > <select name="profile" id="profile"> > <option value="">Do not use profile</option> > </select> >@@ -145,6 +145,7 @@ > <input type="hidden" name="uploadedfileid" id="uploadedfileid" value="" /> > <input type="hidden" name="runinbackground" id="runinbackground" value="" /> > <input type="hidden" name="completedJobID" id="completedJobID" value="" /> >+ <legend>Settings</legend> > <ol><li> > <label for="comments">Comments about this file: </label> > <input type="text" id="comments" name="comments" /> >@@ -182,12 +183,12 @@ > > [% IF MarcModificationTemplatesLoop %] > <fieldset class="rows"> >- <legend>Use MARC Modification Template:</legend> >+ <legend>Modify records using a MARC modification template?</legend> > <ol> > <li> >- <label for="comments">Modify record using the following template: </label> >+ <label for="comments">Template: </label> > <select name="marc_modification_template_id" id="marc_modification_template_id"> >- <option value="">Do not use.</option> >+ <option value="">Do not use template</option> > [% FOREACH mmt IN MarcModificationTemplatesLoop %] > <option value="[% mmt.template_id | html %]">[% mmt.name | html %]</option> > [% END %] >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28839
:
123720
|
123721
|
123722
|
123806
|
123821
|
123822
|
123871
|
123872