From 744c8e644298b8ffb526ca2042545ab842b483d9 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 10 Sep 2020 11:21:59 -0400
Subject: [PATCH] Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 admin/columns_settings.yml                                  | 4 ++++
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index 8c87f4f050..d137f39aa9 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -310,6 +310,8 @@ modules:
               columnname: holdings_homebranch
             -
               columnname: holdings_ccode
+            -
+              columnname: holdings_volume
             -
               columnname: holdings_itemcallnumber
             -
@@ -367,6 +369,8 @@ modules:
               columnname: otherholdings_homebranch
             -
               columnname: otherholdings_ccode
+            -
+              columnname: otherholdings_volume
             -
               columnname: otherholdings_itemcallnumber
             -
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index eed463e707..1987cf318f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -328,7 +328,9 @@
                 <th id="[% tab | html %]_holdingbranch" data-colname="[% tab | html %]_holdingbranch">Current library</th>
                 <th id="[% tab | html %]_homebranch" data-colname="[% tab | html %]_homebranch">Home library</th>
                 [% IF ( itemdata_ccode ) %]<th id="[% tab | html %]_ccode" data-colname="[% tab | html %]_ccode">Collection</th>[% END %]
-                [% IF Koha.Preference('EnableVolumes') %]<th>Volume</th>[% END %]
+                [% IF Koha.Preference('EnableVolumes') %]
+                    <th id="[% tab | html %]_volume" data-colname="[% tab | html %]_volume">Volume</th>
+                [% END %]
                 <th id="[% tab | html %]_itemcallnumber" data-colname="[% tab | html %]_itemcallnumber">Call number</th>
                 [% IF volinfo %]
                     <th id="[% tab | html %]_enumchron" data-colname="[% tab | html %]_enumchron">Serial enumeration / chronology</th>
@@ -403,7 +405,7 @@ Note that permanent location is a code, and location may be an authval.
                         </span>
                     </td>
                     [% IF ( itemdata_ccode ) %]<td>[% item.ccode | html %]</td>[% END %]
-                    [% IF Koha.Preference('EnableVolumes') %]<td>[% item.object.volume.description | html %]</td>[% END %]
+                    [% IF Koha.Preference('EnableVolumes') %]<td class="volume">[% item.object.volume.description | html %]</td>[% END %]
                     <td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td>
                     [% IF ( volinfo ) %]
                         [% IF itemdata_publisheddate #If there is at least one published date, use it for sorting %]
-- 
2.30.2