Bugzilla – Attachment 123937 Details for
Bug 25078
Update DB process - wrap each DBRev inside a transaction and better error handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25078: Explicitely return from DB revs to avoid warnings
Bug-25078-Explicitely-return-from-DB-revs-to-avoid.patch (text/plain), 8.01 KB, created by
Jonathan Druart
on 2021-08-18 11:00:57 UTC
(
hide
)
Description:
Bug 25078: Explicitely return from DB revs to avoid warnings
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-08-18 11:00:57 UTC
Size:
8.01 KB
patch
obsolete
>From f90d2378503e93bba176c12c160792f5cdb11252 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Aug 2021 12:57:51 +0200 >Subject: [PATCH] Bug 25078: Explicitely return from DB revs to avoid warnings > >% perl -wc installer/data/mysql/atomicupdate/skeleton.pl >Useless use of anonymous hash ({}) in void context at installer/data/mysql/atomicupdate/skeleton.pl >--- > installer/data/mysql/atomicupdate/skeleton.pl | 2 +- > installer/data/mysql/db_revs/210600000.pl | 2 +- > installer/data/mysql/db_revs/210600001.pl | 2 +- > installer/data/mysql/db_revs/210600002.pl | 2 +- > installer/data/mysql/db_revs/210600004.pl | 2 +- > installer/data/mysql/db_revs/210600005.pl | 2 +- > installer/data/mysql/db_revs/210600006.pl | 2 +- > installer/data/mysql/db_revs/210600007.pl | 2 +- > installer/data/mysql/db_revs/210600008.pl | 2 +- > installer/data/mysql/db_revs/210600009.pl | 2 +- > installer/data/mysql/db_revs/210600010.pl | 2 +- > installer/data/mysql/db_revs/210600011.pl | 2 +- > installer/data/mysql/db_revs/210600012.pl | 2 +- > installer/data/mysql/db_revs/210600013.pl | 2 +- > installer/data/mysql/db_revs/210600014.pl | 2 +- > installer/data/mysql/db_revs/210600015.pl | 2 +- > installer/data/mysql/db_revs/210600016.pl | 2 +- > 17 files changed, 17 insertions(+), 17 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/skeleton.pl b/installer/data/mysql/atomicupdate/skeleton.pl >index 082f47e0245..5709cd56f2a 100755 >--- a/installer/data/mysql/atomicupdate/skeleton.pl >+++ b/installer/data/mysql/atomicupdate/skeleton.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "BUG_NUMBER", > description => "A single line description", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600000.pl b/installer/data/mysql/db_revs/210600000.pl >index a9d08fef02c..aa0fdb51605 100755 >--- a/installer/data/mysql/db_revs/210600000.pl >+++ b/installer/data/mysql/db_revs/210600000.pl >@@ -2,7 +2,7 @@ use Modern::Perl; > use utf8; > use Encode qw( encode_utf8 ); > >-{ >+return { > bug_number => undef, > description => 'Increase DBRev for 21.06', > up => sub { >diff --git a/installer/data/mysql/db_revs/210600001.pl b/installer/data/mysql/db_revs/210600001.pl >index ee84b39907e..41064b351f1 100755 >--- a/installer/data/mysql/db_revs/210600001.pl >+++ b/installer/data/mysql/db_revs/210600001.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "28489", > description => "Modify sessions.a_session from longtext to longblob", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600002.pl b/installer/data/mysql/db_revs/210600002.pl >index 25e0f6d9e7b..c847d7f5b39 100755 >--- a/installer/data/mysql/db_revs/210600002.pl >+++ b/installer/data/mysql/db_revs/210600002.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "28490", > description => "Bring back accidentally deleted relationship columns", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600004.pl b/installer/data/mysql/db_revs/210600004.pl >index e8a08841f04..5729dcbad3a 100755 >--- a/installer/data/mysql/db_revs/210600004.pl >+++ b/installer/data/mysql/db_revs/210600004.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "15788", > description => "Split edit_borrowers permission", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600005.pl b/installer/data/mysql/db_revs/210600005.pl >index 8386af88780..883fd0e3ede 100755 >--- a/installer/data/mysql/db_revs/210600005.pl >+++ b/installer/data/mysql/db_revs/210600005.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "26205", > description => "Add new system preference NewsLog to log news changes", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600006.pl b/installer/data/mysql/db_revs/210600006.pl >index 38536485a72..d2ea29de948 100755 >--- a/installer/data/mysql/db_revs/210600006.pl >+++ b/installer/data/mysql/db_revs/210600006.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "14237", > description => "Add individual bibliographic records to course reserves", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600007.pl b/installer/data/mysql/db_revs/210600007.pl >index 7bef60a8cd0..56ff03d5676 100755 >--- a/installer/data/mysql/db_revs/210600007.pl >+++ b/installer/data/mysql/db_revs/210600007.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "11879", > description => "Add a new field to patron record: main contact method", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600008.pl b/installer/data/mysql/db_revs/210600008.pl >index 1c82f5c94ee..431d7f85ce2 100755 >--- a/installer/data/mysql/db_revs/210600008.pl >+++ b/installer/data/mysql/db_revs/210600008.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "20310", > description => "Add new system preference ArticleRequestsOpacHostRedirection", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600009.pl b/installer/data/mysql/db_revs/210600009.pl >index 174e2048d16..b0bd5a2b429 100755 >--- a/installer/data/mysql/db_revs/210600009.pl >+++ b/installer/data/mysql/db_revs/210600009.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "20472", > description => "Add columns format and urls in article_requests table", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600010.pl b/installer/data/mysql/db_revs/210600010.pl >index 484ee395e03..8af6bb6fe33 100755 >--- a/installer/data/mysql/db_revs/210600010.pl >+++ b/installer/data/mysql/db_revs/210600010.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "20472", > description => "Add new system preference ArticleRequestsSupportedFormats", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600011.pl b/installer/data/mysql/db_revs/210600011.pl >index 12f7dd29ba2..d3c35b345f9 100755 >--- a/installer/data/mysql/db_revs/210600011.pl >+++ b/installer/data/mysql/db_revs/210600011.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "28567", > description => "Set to NULL empty branches fields", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600012.pl b/installer/data/mysql/db_revs/210600012.pl >index c46644f887e..fef986078be 100755 >--- a/installer/data/mysql/db_revs/210600012.pl >+++ b/installer/data/mysql/db_revs/210600012.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "15067", > description => "Add missing languages", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600013.pl b/installer/data/mysql/db_revs/210600013.pl >index c73edc7cbbc..a8e52eaaf65 100755 >--- a/installer/data/mysql/db_revs/210600013.pl >+++ b/installer/data/mysql/db_revs/210600013.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "22435", > description => "Update existing offsets", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600014.pl b/installer/data/mysql/db_revs/210600014.pl >index 76017c718e8..c56acf6fe40 100755 >--- a/installer/data/mysql/db_revs/210600014.pl >+++ b/installer/data/mysql/db_revs/210600014.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "28813", > description => "Update delivery_note to failure_code in message_queue", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600015.pl b/installer/data/mysql/db_revs/210600015.pl >index 9b53ba0e3af..af3b8b8bf64 100755 >--- a/installer/data/mysql/db_revs/210600015.pl >+++ b/installer/data/mysql/db_revs/210600015.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "12561", > description => "Remove system preferences HighlightOwnItemsOnOPAC and HighlightOwnItemsOnOPACWhich", > up => sub { >diff --git a/installer/data/mysql/db_revs/210600016.pl b/installer/data/mysql/db_revs/210600016.pl >index 27aa7d07b00..05b05442509 100755 >--- a/installer/data/mysql/db_revs/210600016.pl >+++ b/installer/data/mysql/db_revs/210600016.pl >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-{ >+return { > bug_number => "24387", > description => "Rename opac_news with additional_contents", > up => sub { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25078
:
102521
|
116032
|
116033
|
116034
|
116208
|
116209
|
117084
|
121909
|
121910
|
121911
|
121982
|
121983
|
121984
|
122208
|
122322
|
122323
|
122324
|
122325
|
122326
|
122329
|
122665
|
122666
|
122667
|
122668
|
122669
|
122670
|
122671
|
122679
|
122680
|
122875
|
123356
|
123357
|
123358
|
123359
|
123360
|
123361
|
123362
|
123363
|
123364
|
123365
|
123366
|
123367
|
123850
|
123851
|
123853
| 123937 |
124269