Bugzilla – Attachment 123959 Details for
Bug 28525
TinyMCE for system prefs does some automatic code clean up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28525: Dont let TinyMCE do code cleanup
Bug-28525-Dont-let-TinyMCE-do-code-cleanup.patch (text/plain), 2.22 KB, created by
Jonathan Druart
on 2021-08-18 13:10:52 UTC
(
hide
)
Description:
Bug 28525: Dont let TinyMCE do code cleanup
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-08-18 13:10:52 UTC
Size:
2.22 KB
patch
obsolete
>From fe4fc37014c58d9875d4838057d218b88aaa423b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 7 Jun 2021 22:17:46 +0000 >Subject: [PATCH] Bug 28525: Dont let TinyMCE do code cleanup >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If you look at Bug 24764 and Bug 26942 we adjusted the TinyMCE for the News tool so it will not do some types of automatic code clean up. > >The TinyMCE editor for system preferences which can be enabled by 'UseWYSIWYGinSystemPreferences' has the same problems. > >We should make the configurations the same. > >To Test: >1. Turn on 'UseWYSIWYGinSystemPreferences' >2. Go to a system preference like 'RestrictedPageContent' >3. Try entering something like '<i class="fa fa-facebook-official" aria-hidden="true">TEST</i>' in the Source Code window >4. It gets cleaned up by the editor >5. Try something like '<a href="https://www.test.com" referrerpolicy=""no-referrer-when-downgrade">TEST</a>' >6. It's cleaned up by the editor. >7. Try something like '<link href="https://fonts.googleapis.com/css?family=Open+Sansâ rel=âstylesheet">' >8. Cleaned up by editor. >9. Apply patch >10. Try step 3, 5, and 7 again. >11. It should not be changed by the editor > >Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/includes/wysiwyg-systempreferences.inc | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >index f1e8be331a6..c6875c01ae1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >@@ -13,6 +13,12 @@ > } > > tinyMCE.init({ >+ verify_html: false, >+ force_br_newlines : false, >+ force_p_newlines : false, >+ forced_root_block : '', >+ extended_valid_elements:"style,link[href|rel]", >+ custom_elements:"style,link,~link", > branding : false, > relative_urls : false, > content_css : "[% interface | html %]/[% theme | html %]/css/tinymce.css", >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28525
:
121698
|
123717
|
123919
| 123959