Bugzilla – Attachment 123979 Details for
Bug 28881
Suggestion not displayed on the order receive page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page
Bug-28881-bug-23376-follow-up-Fix-suggestion-displ.patch (text/plain), 1.57 KB, created by
David Nind
on 2021-08-19 18:21:46 UTC
(
hide
)
Description:
Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-08-19 18:21:46 UTC
Size:
1.57 KB
patch
obsolete
>From 37e236fda52e89bbf5a3e5d0629406cfaa0e1b4f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 19 Aug 2021 12:34:58 +0200 >Subject: [PATCH] Bug 28881: (bug 23376 follow-up) Fix suggestion display on > order receive page > >On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 >occurrences have not been corrected. > >It causes a bug on the order receive page when the bib is linked with a >suggestion. > >Test plan: >Create an order from bib A, create a suggestion for purchase on bib A >(OPAC) >Receive the order. >Without the patch: Notice the "Suggested by: (suggestion #)" >With the patch you see the info of the suggester > >Signed-off-by: David Nind <david@davidnind.com> >--- > acqui/orderreceive.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl >index f684a8ed7a..588b465d38 100755 >--- a/acqui/orderreceive.pl >+++ b/acqui/orderreceive.pl >@@ -164,7 +164,7 @@ $template->param( > gst_values => \@gst_values, > ); > >-my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber}); >+my $suggestion = GetSuggestionInfoFromBiblionumber($order->biblionumber); > if ( $suggestion ) { > $template->param( suggestion => $suggestion ); > } >@@ -188,7 +188,7 @@ foreach my $period (@$periods) { > { > b_id => $r->{budget_id}, > b_txt => $r->{budget_name}, >- b_sel => ( $r->{budget_id} == $order->{budget_id} ) ? 1 : 0, >+ b_sel => ( $r->{budget_id} == $order->budget_id ) ? 1 : 0, > }; > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28881
:
123969
|
123979
|
124130