Bugzilla – Attachment 123994 Details for
Bug 28883
Koha::Objects->_new_from_dbic doesn't work correctly in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28883: (QA follow-up) Improve test description
Bug-28883-QA-follow-up-Improve-test-description.patch (text/plain), 1.27 KB, created by
Marcel de Rooy
on 2021-08-20 08:48:21 UTC
(
hide
)
Description:
Bug 28883: (QA follow-up) Improve test description
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-08-20 08:48:21 UTC
Size:
1.27 KB
patch
obsolete
>From 75be8be1eea299c52992b4e8463b0e8843fecfb8 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 20 Aug 2021 07:41:37 +0000 >Subject: [PATCH] Bug 28883: (QA follow-up) Improve test description >Content-Type: text/plain; charset=utf-8 > >Copy-pasted descriptions. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/Objects.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t >index fec3a81193..916d1d4788 100755 >--- a/t/db_dependent/Koha/Objects.t >+++ b/t/db_dependent/Koha/Objects.t >@@ -1299,10 +1299,10 @@ subtest '_new_from_dbic() tests' => sub { > $items_scalar = $biblio->items; > @items_list = $biblio->items; > >- is( $items_scalar->count, 2, 'No items in resultset' ); >- is( scalar @items_list, 2, 'Empty list in list context' ); >+ is( $items_scalar->count, 2, 'Check count on resultset' ); >+ is( scalar @items_list, 2, 'Check number of entries returned in list context' ); > is( $items_list[0]->itemnumber, $item_1->itemnumber, 'First element correct' ); > is( $items_list[1]->itemnumber, $item_2->itemnumber, 'Second element correct' ); > > $schema->storage->txn_rollback; >-}; >\ No newline at end of file >+}; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28883
:
123976
|
123977
|
123980
|
123981
|
123992
|
123993
| 123994 |
123995
|
124181
|
124420