From 9dde31ca4be9bb6b488b04cad5f412ed6889cd4c Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Wed, 26 Feb 2020 14:59:40 -0500
Subject: [PATCH] Bug 24857: Add ability to manage item's volumes from
 detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 Koha/Biblio.pm                                |   3 +-
 catalogue/detail.pl                           |  42 ++++++-
 .../prog/en/modules/catalogue/detail.tt       | 109 +++++++++++++++++-
 3 files changed, 150 insertions(+), 4 deletions(-)

diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
index 6b3d04f81a..d415269ca9 100644
--- a/Koha/Biblio.pm
+++ b/Koha/Biblio.pm
@@ -35,13 +35,14 @@ use Koha::ArticleRequest::Status;
 use Koha::ArticleRequests;
 use Koha::Biblio::Metadatas;
 use Koha::Biblio::Volumes;
+use Koha::Biblio::Volumes;
 use Koha::Biblioitems;
 use Koha::CirculationRules;
 use Koha::Item::Transfer::Limits;
 use Koha::Items;
 use Koha::Libraries;
-use Koha::Suggestions;
 use Koha::Subscriptions;
+use Koha::Suggestions;
 
 =head1 NAME
 
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index 0cb204ced9..c5c9792a24 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -46,15 +46,17 @@ use Koha::DateUtils qw( format_sqldatetime );
 use C4::HTML5Media;
 use C4::CourseReserves qw( GetItemCourseReservesInfo );
 use Koha::AuthorisedValues;
+use Koha::Biblio::Volume::Items;
 use Koha::Biblios;
 use Koha::CoverImages;
+use Koha::DateUtils;
 use Koha::Illrequests;
-use Koha::Items;
 use Koha::ItemTypes;
+use Koha::Items;
 use Koha::Patrons;
-use Koha::Virtualshelves;
 use Koha::Plugins;
 use Koha::SearchEngine::Search;
+use Koha::Virtualshelves;
 
 my $query = CGI->new();
 
@@ -97,6 +99,41 @@ if ( not defined $record ) {
 eval { $biblio->metadata->record };
 $template->param( decoding_error => $@ );
 
+my $op = $query->param('op') || q{};
+if ( $op eq 'set_volume' ) {
+    my $volume_id   = $query->param('volume_id');
+    my @itemnumbers = $query->multi_param('itemnumber');
+
+    foreach my $itemnumber (@itemnumbers) {
+        my $volume_item =
+          Koha::Biblio::Volume::Items->find( { itemnumber => $itemnumber } );
+
+        if ($volume_item) {
+            $volume_item->volume_id($volume_id);
+        }
+        else {
+            $volume_item = Koha::Biblio::Volume::Item->new(
+                {
+                    itemnumber => $itemnumber,
+                    volume_id  => $volume_id,
+                }
+            );
+        }
+
+        $volume_item->store();
+    }
+}
+elsif ( $op eq 'unset_volume' ) {
+    my $volume_id   = $query->param('volume_id');
+    my @itemnumbers = $query->multi_param('itemnumber');
+
+    foreach my $itemnumber (@itemnumbers) {
+        my $volume_item =
+          Koha::Biblio::Volume::Items->find( { itemnumber => $itemnumber } );
+        $volume_item->delete() if $volume_item;
+    }
+}
+
 if($query->cookie("holdfor")){
     my $holdfor_patron = Koha::Patrons->find( $query->cookie("holdfor") );
     if ( $holdfor_patron ) {
@@ -329,6 +366,7 @@ foreach my $item (@items) {
 
     # checking for holds
     my $item_object = Koha::Items->find( $item->{itemnumber} );
+    $item->{object} = $item_object;
     my $holds = $item_object->current_holds;
     if ( my $first_hold = $holds->next ) {
         $item->{first_hold} = $first_hold;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 10596b14e7..ca3777524c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -310,6 +310,10 @@
               [% IF CAN_user_tools_items_batchmod %]
                 <a class="itemselection_action_modify"><i class="fa fa-pencil"></i> Modify selected items</a>
               [% END %]
+              [% IF biblio.volumes.count %]
+                <a class="itemselection_action_volume_set" href="#"><i class="fa fa-book"></i> Add/move to volume</a>
+                <a class="itemselection_action_volume_unset" href="#"><i class="fa fa-unlink"></i> Remove from volume</a>
+              [% END %]
             </span>
         [% END %]
     </div>
@@ -324,6 +328,7 @@
                 <th id="[% tab | html %]_holdingbranch" data-colname="[% tab | html %]_holdingbranch">Current library</th>
                 <th id="[% tab | html %]_homebranch" data-colname="[% tab | html %]_homebranch">Home library</th>
                 [% IF ( itemdata_ccode ) %]<th id="[% tab | html %]_ccode" data-colname="[% tab | html %]_ccode">Collection</th>[% END %]
+                [% IF Koha.Preference('EnableVolumes') %]<th>Volume</th>[% END %]
                 <th id="[% tab | html %]_itemcallnumber" data-colname="[% tab | html %]_itemcallnumber">Call number</th>
                 [% IF volinfo %]
                     <th id="[% tab | html %]_enumchron" data-colname="[% tab | html %]_enumchron">Serial enumeration / chronology</th>
@@ -398,6 +403,7 @@ Note that permanent location is a code, and location may be an authval.
                         </span>
                     </td>
                     [% IF ( itemdata_ccode ) %]<td>[% item.ccode | html %]</td>[% END %]
+                    [% IF Koha.Preference('EnableVolumes') %]<td>[% item.object.volume.description | html %]</td>[% END %]
                     <td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td>
                     [% IF ( volinfo ) %]
                         [% IF itemdata_publisheddate #If there is at least one published date, use it for sorting %]
@@ -1102,7 +1108,7 @@ Note that permanent location is a code, and location may be an authval.
     </div>
 </div>
 
-<div class="modal fade" id="modal-volume-delete" tabindex="-1" role="dialog" aria-labelledby="modal-volume-create-label">
+<div class="modal fade" id="modal-volume-delete" tabindex="-1" role="dialog" aria-labelledby="modal-volume-delete-label">
     <div class="modal-dialog">
         <div class="modal-content">
             <div class="modal-header">
@@ -1120,6 +1126,54 @@ Note that permanent location is a code, and location may be an authval.
     </div>
 </div>
 
+<div class="modal fade" id="modal-volume-set" tabindex="-1" role="dialog" aria-labelledby="modal-volume-set-label">
+    <div class="modal-dialog">
+        <div class="modal-content">
+            <div class="modal-header">
+                <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">×</button>
+                <h3 id="modal-volume-set-label"><i class='fa fa-book'></i> Set volume for items</h3>
+            </div>
+            <form id="modal-volume-set-form" class="validated">
+                <div class="modal-body">
+                    <fieldset>
+                        <p>
+                            <label for="volume" class="required">Volume: </label>
+                            <select name="volume" id="volume-add-form-select">
+                                [% FOREACH v IN biblio.volumes %]
+                                    <option value="[% v.id | html %]">[% v.description | html %]</option>
+                                [% END %]
+                            </select>
+                            <span class="required">Required</span>
+                        </p>
+                    </fieldset>
+                </div>
+                <div class="modal-footer">
+                    <button id="modal-volume-set-submit" class="btn btn-default"><i class='fa fa-book'></i> Set volume</button>
+                    <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button>
+                </div>
+            </form>
+        </div>
+    </div>
+</div>
+
+<div class="modal fade" id="modal-volume-unset" tabindex="-1" role="dialog" aria-labelledby="modal-volume-unset-label">
+    <div class="modal-dialog">
+        <div class="modal-content">
+            <div class="modal-header">
+                <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">×</button>
+                <h3 id="modal-volume-unset-label"><i class='fa fa-unlink'></i> Remove item from volume</h3>
+            </div>
+            <div class="modal-body">
+                Are you sure you want to remove these item(s) from their volume(s)?
+            </div>
+            <div class="modal-footer">
+                <button id="modal-volume-unset-submit" class="btn btn-danger"><i class='fa fa-unlink'></i> Remove</button>
+                <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button>
+            </div>
+        </div>
+    </div>
+</div>
+
 [% MACRO jsinclude BLOCK %]
     [% INCLUDE 'catalog-strings.inc' %]
     [% Asset.js("js/catalog.js") | $raw %]
@@ -1654,6 +1708,59 @@ Note that permanent location is a code, and location may be an authval.
                     }
                 });
             });
+
+            // Add item(s) to a volume
+            $('.itemselection_action_volume_set').on('click', function(){
+                $('#modal-volume-set').modal('show');
+            });
+
+            $("#modal-volume-set-form").validate({
+                submitHandler: function(form) {
+                    $('#modal-volume-set-submit').attr('disabled', 'disabled');
+
+                    const volume_id = $('#volume-add-form-select').val();
+
+                    let itemnumbers = new Array();
+                    $("input[name='itemnumber'][type='checkbox']:checked").each(function() {
+                        const itemnumber = $(this).val();
+                        itemnumbers.push( itemnumber );
+                    });
+                    if (itemnumbers.length > 0) {
+                        let url = '/cgi-bin/koha/catalogue/detail.pl?op=set_volume';
+                        url += '&itemnumber=' + itemnumbers.join('&itemnumber=');
+                        url += '&biblionumber=[% biblionumber | uri %]';
+                        url += `&volume_id=${volume_id}`;
+
+                        window.location.replace(url);
+                    }
+
+                    $('#modal-volume-set').modal('hide');
+                }
+            });
+
+            // Remove item(s) from a volume
+            $('.itemselection_action_volume_unset').on('click', function(){
+                $('#modal-volume-unset').modal('show');
+            });
+
+            $("#modal-volume-unset-submit").on('click', function(){
+                $('#modal-volume-unset-submit').attr('disabled', 'disabled');
+
+                let itemnumbers = new Array();
+                $("input[name='itemnumber'][type='checkbox']:checked").each(function() {
+                    const itemnumber = $(this).val();
+                    itemnumbers.push( itemnumber );
+                });
+                if (itemnumbers.length > 0) {
+                    let url = '/cgi-bin/koha/catalogue/detail.pl?op=unset_volume';
+                    url += '&itemnumber=' + itemnumbers.join('&itemnumber=');
+                    url += '&biblionumber=[% biblionumber | uri %]';
+
+                    window.location.replace(url);
+                }
+
+                $('#modal-volume-unset').modal('hide');
+            });
         [% END %]
     </script>
 [% END %]
-- 
2.30.2