From e32a51d882881ee2e03b992432c0794b330fc2fc Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 26 Aug 2021 17:21:32 +0200 Subject: [PATCH] Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi --- opac/opac-memberentry.pl | 2 +- t/Koha/Email.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl index 1ae2ebe281..cce33d8c8b 100755 --- a/opac/opac-memberentry.pl +++ b/opac/opac-memberentry.pl @@ -439,7 +439,7 @@ sub CheckForInvalidFields { my $borrower = shift; my @invalidFields; if ($borrower->{'email'}) { - unless ( Koha::Email->is_valid($borrower->{email}) { + unless ( Koha::Email->is_valid($borrower->{email}) ) { push(@invalidFields, "email"); } elsif ( C4::Context->preference("PatronSelfRegistrationEmailMustBeUnique") ) { my $patrons_with_same_email = Koha::Patrons->search( # FIXME Should be search_limited? diff --git a/t/Koha/Email.t b/t/Koha/Email.t index f47a0908cd..a329950a37 100755 --- a/t/Koha/Email.t +++ b/t/Koha/Email.t @@ -255,10 +255,10 @@ subtest 'is_valid' => sub { is(Koha::Email->is_valid('Fróm '), 1); is(Koha::Email->is_valid('from@example.com'), 1); is(Koha::Email->is_valid(''), 1); + is(Koha::Email->is_valid('root@localhost'), 1); # See bug 28017 is(Koha::Email->is_valid(''), 0); # "In accordance with RFC 822 and its descendants, this module demands that email addresses be ASCII only" isnt(Koha::Email->is_valid('@example.com'), 1); isnt(Koha::Email->is_valid('example.com'), 1); - isnt(Koha::Email->is_valid('root@localhost'), 1); isnt(Koha::Email->is_valid('from'), 1); }; -- 2.30.2