From 5f2b501deec85c514bcbf45131583d4449d45104 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 23 Jul 2021 00:35:49 -0300 Subject: [PATCH] Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD amended patch: remove uneeded commented lines --- t/db_dependent/Koha/Object.t | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t index 64d3f1d9ea2..a1e10e846a3 100755 --- a/t/db_dependent/Koha/Object.t +++ b/t/db_dependent/Koha/Object.t @@ -390,7 +390,7 @@ subtest "to_api_mapping() tests" => sub { subtest "from_api_mapping() tests" => sub { - plan tests => 3; + plan tests => 5; $schema->storage->txn_begin; @@ -449,6 +449,28 @@ subtest "from_api_mapping() tests" => sub { 'Fresh mapping loaded' ); + $city_class->unmock( 'to_api_mapping'); + $city_class->mock( 'to_api_mapping', undef ); + + # Get a fresh object + $city = $builder->build_object({ class => 'Koha::Cities' }); + is_deeply( + $city->from_api_mapping, + {}, + 'No to_api_mapping then empty hashref' + ); + + $city_class->unmock( 'to_api_mapping'); + $city_class->mock( 'to_api_mapping', sub { return; } ); + + # Get a fresh object + $city = $builder->build_object({ class => 'Koha::Cities' }); + is_deeply( + $city->from_api_mapping, + {}, + 'Empty to_api_mapping then empty hashref' + ); + $schema->storage->txn_rollback; }; -- 2.25.1