Bugzilla – Attachment 124196 Details for
Bug 28914
Wrong wording in authentication forms
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28914: Uniform wording in authentication forms
Bug-28914-Uniform-wording-in-authentication-forms.patch (text/plain), 4.21 KB, created by
Fridolin Somers
on 2021-08-27 18:45:00 UTC
(
hide
)
Description:
Bug 28914: Uniform wording in authentication forms
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2021-08-27 18:45:00 UTC
Size:
4.21 KB
patch
obsolete
>From 331ecc8fc0b81330e0bc2e2ea47253f89213f022 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 27 Aug 2021 08:37:03 -1000 >Subject: [PATCH] Bug 28914: Uniform wording in authentication forms > >In most authentication forms we see : >Fields "Login:" and "Password:" with a submit button "Log in". > >In some places submit button contains "Login", which is confusing for translation. >Also in opac-user.pl ":" is missing. > >I propose we always use : >Fields "Login:", "Password:" with a submit button "Log in". >It will generate less translation entries. > >Test plan: >1) Log out if you are logged in >2) Go to staff interface >3) Check you see field "Login:" and button "Log in" >4) Same for webinstaller >5) Go to OPAC page /cgi-bin/koha/opac-user.pl >6) Check you see fields "Login:" and "Password:" >--- > koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >index da9c0c14c4..e26f0100e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >@@ -68,7 +68,7 @@ > [% FOREACH INPUT IN INPUTS %] > <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" /> > [% END %] >- <p><label for="userid">Username:</label> >+ <p><label for="userid">Login:</label> > <input type="text" name="userid" id="userid" class="input focus" value="[% userid | html %]" size="20" tabindex="1" /> > </p> > <p><label for="password">Password:</label> >@@ -112,7 +112,7 @@ > > <!-- <p><label><input name="rememberme" type="checkbox" id="rememberme" value="forever" tabindex="3" />Remember me</label></p> --> > >- <p class="submit"><input id="submit-button" type="submit" value="Login" tabindex="4" /></p> >+ <p class="submit"><input id="submit-button" type="submit" value="Log in" tabindex="4" /></p> > </form> > > [% IF ( casAuthentication ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt >index 1fe4efa0e1..0928e8e573 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt >@@ -47,7 +47,7 @@ > <legend>Please enter your username and password</legend> > > <div class="form-group"> >- <label>Username:</label> >+ <label>Login:</label> > <input type="text" class="form-control" name="userid" id="userid" value="[% userid | html %]" size="20" tabindex="1" /> > </div> > <div class="form-group"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index 4e13defc68..e8b03356fa 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -183,11 +183,11 @@ > <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" /> > [% END %] > <div class="form-group"> >- <label for="userid">Login</label> >+ <label for="userid">Login:</label> > <input class="form-control" type="text" size="25" id="userid" name="userid" /> > </div> > <div class="form-group"> >- <label for="password">Password</label> >+ <label for="password">Password:</label> > <input class="form-control" type="password" size="25" id="password" name="password" /> > </div> > <fieldset class="action"> >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28914
:
124196
|
124216
|
124218
|
124872
|
124882
|
125023