View | Details | Raw Unified | Return to bug 20256
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Patrons.t (-2 / +76 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 42;
22
use Test::More tests => 43;
23
use Test::Warn;
23
use Test::Warn;
24
use Test::Exception;
24
use Test::Exception;
25
use Test::MockModule;
25
use Test::MockModule;
Lines 2184-2187 subtest 'queue_notice' => sub { Link Here
2184
    is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter,"Count of queued notices not increased in test mode");
2184
    is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter,"Count of queued notices not increased in test mode");
2185
};
2185
};
2186
2186
2187
subtest 'libraries_where_can_edit_items + can_edit_item' => sub {
2188
    plan tests => 2;
2189
2190
    $schema->storage->txn_begin;
2191
    my $dbh = $schema->storage->dbh;
2192
2193
    $dbh->do("DELETE FROM library_groups");
2194
2195
    # group1
2196
    #   library_1A
2197
    #   library_1B
2198
    # group2
2199
    #   library_2A
2200
    my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_limit_item_editing => 1 } )->store;
2201
    my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_limit_item_editing => 1 } )->store;
2202
    my $library_1A = $builder->build( { source => 'Branch' } );
2203
    my $library_1B = $builder->build( { source => 'Branch' } );
2204
    my $library_2A = $builder->build( { source => 'Branch' } );
2205
    $library_1A = Koha::Libraries->find( $library_1A->{branchcode} );
2206
    $library_1B = Koha::Libraries->find( $library_1B->{branchcode} );
2207
    $library_2A = Koha::Libraries->find( $library_2A->{branchcode} );
2208
    Koha::Library::Group->new( { branchcode => $library_1A->branchcode, parent_id => $group_1->id } )->store;
2209
    Koha::Library::Group->new( { branchcode => $library_1B->branchcode, parent_id => $group_1->id } )->store;
2210
    Koha::Library::Group->new( { branchcode => $library_2A->branchcode, parent_id => $group_2->id } )->store;
2211
2212
    my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 9, ?)|); # 9 for editcatalogue
2213
    # 2 patrons from library_1A (group1)
2214
    # patron_1A_1 see patron's infos from outside its group
2215
    # Setting flags => undef to not be considered as superlibrarian
2216
    my $patron_1A_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2217
    $patron_1A_1 = Koha::Patrons->find( $patron_1A_1->{borrowernumber} );
2218
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_items' );
2219
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_any_item' );
2220
    # patron_1A_2 can only see patron's info from its group
2221
    my $patron_1A_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2222
    $patron_1A_2 = Koha::Patrons->find( $patron_1A_2->{borrowernumber} );
2223
    $sth->execute( $patron_1A_2->borrowernumber, 'edit_items' );
2224
    # 1 patron from library_1B (group1)
2225
    my $patron_1B = $builder->build({ source => 'Borrower', value => { branchcode => $library_1B->branchcode, flags => undef, }});
2226
    $patron_1B = Koha::Patrons->find( $patron_1B->{borrowernumber} );
2227
    # 1 patron from library_2A (group2) can only see patron's info from its group
2228
    my $patron_2A = $builder->build({ source => 'Borrower', value => { branchcode => $library_2A->branchcode, flags => undef, }});
2229
    $patron_2A = Koha::Patrons->find( $patron_2A->{borrowernumber} );
2230
    $sth->execute( $patron_2A->borrowernumber, 'edit_items' );
2231
2232
    subtest 'libraries_where_can_edit_items' => sub {
2233
        plan tests => 3;
2234
2235
        my @branchcodes;
2236
2237
        @branchcodes = $patron_1A_1->libraries_where_can_edit_items;
2238
        is_deeply( \@branchcodes, [], "patron_1A_1 has edit_any_item => No restrictions" );
2239
2240
        @branchcodes = $patron_1A_2->libraries_where_can_edit_items;
2241
        is_deeply( \@branchcodes, [ sort ( $library_1A->branchcode, $library_1B->branchcode ) ], "patron_1A_2 doesn't have edit_any_item => Can only edit items from its group" );
2242
2243
        @branchcodes = $patron_2A->libraries_where_can_edit_items;
2244
        is_deeply( \@branchcodes, [$library_2A->branchcode], "patron_2A doesn't have edit_any_item => Can only see patron's from its group" );
2245
    };
2246
2247
    subtest 'can_edit_item' => sub {
2248
        plan tests => 6;
2249
2250
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_1 });
2251
        is( $patron_1A_1->can_edit_item( $library_1A->id ), 1, "patron_1A_1 can see patron_1A_2, from its library" );
2252
        is( $patron_1A_1->can_edit_item( $library_1B->id ),   1, "patron_1A_1 can see patron_1B, from its group" );
2253
        is( $patron_1A_1->can_edit_item( $library_2A->id ),   1, "patron_1A_1 can see patron_1A_2, from another group" );
2254
2255
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_2 });
2256
        is( $patron_1A_2->can_edit_item( $library_1A->id ),   1, "patron_1A_2 can see patron_1A_1, from its library" );
2257
        is( $patron_1A_2->can_edit_item( $library_1B->id ),   1, "patron_1A_2 can see patron_1B, from its group" );
2258
        is( $patron_1A_2->can_edit_item( $library_2A->id ),   0, "patron_1A_2 can NOT see patron_2A, from another group" );
2259
    };
2260
};
2261
2187
$schema->storage->txn_rollback;
2262
$schema->storage->txn_rollback;
2188
- 

Return to bug 20256