From 583d20caa6f478e7e25c200d89df064455b938a4 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Wed, 26 Feb 2020 13:20:45 -0500
Subject: [PATCH] Bug 24857: Add ability to attach newly cataloged items to a
 volume

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert@arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 cataloguing/additem.pl                        | 34 +++++++++++++++++++
 .../prog/en/modules/cataloguing/additem.tt    | 30 ++++++++++++++++
 .../prog/js/cataloging_additem.js             | 20 +++++++++++
 3 files changed, 84 insertions(+)

diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
index e099215256..62e6c8ecb9 100755
--- a/cataloguing/additem.pl
+++ b/cataloguing/additem.pl
@@ -43,6 +43,7 @@ use C4::ClassSource qw( GetClassSources GetClassSource );
 use Koha::DateUtils qw( dt_from_string );
 use Koha::Items;
 use Koha::ItemTypes;
+use Koha::Items;
 use Koha::Libraries;
 use Koha::Patrons;
 use Koha::SearchEngine::Indexer;
@@ -84,6 +85,34 @@ sub get_item_from_barcode {
     return($result);
 }
 
+sub add_item_to_volume {
+    my ( $biblionumber, $itemnumber, $volume, $volume_description ) = @_;
+
+    return unless $volume;
+
+    my $volume_id;
+    if ( $volume eq 'create' ) {
+        my $volume = Koha::Biblio::Volume->new(
+            {
+                biblionumber => $biblionumber,
+                description  => $volume_description,
+            }
+        )->store();
+
+        $volume_id = $volume->id;
+    }
+    else {
+        $volume_id = $volume;
+    }
+
+    my $volume_item = Koha::Biblio::Volume::Item->new(
+        {
+            itemnumber => $itemnumber,
+            volume_id  => $volume_id,
+        }
+    )->store();
+}
+
 # NOTE: This code is subject to change in the future with the implemenation of ajax based autobarcode code
 # NOTE: 'incremental' is the ONLY autoBarcode option available to those not using javascript
 sub _increment_barcode {
@@ -423,6 +452,8 @@ my $fa_barcode            = $input->param('barcode');
 my $fa_branch             = $input->param('branch');
 my $fa_stickyduedate      = $input->param('stickyduedate');
 my $fa_duedatespec        = $input->param('duedatespec');
+my $volume                = $input->param('volume');
+my $volume_description    = $input->param('volume_description');
 
 my $frameworkcode = &GetFrameworkCode($biblionumber);
 
@@ -529,6 +560,7 @@ if ($op eq "additem") {
         # if barcode exists, don't create, but report The problem.
         unless ($exist_itemnumber) {
             my ( $oldbiblionumber, $oldbibnum, $oldbibitemnum ) = AddItemFromMarc( $record, $biblionumber );
+            add_item_to_volume( $oldbiblionumber, $oldbibitemnum, $volume, $volume_description );
 
             # Pushing the last created item cookie back
             if ($prefillitem && defined $record) {
@@ -628,6 +660,7 @@ if ($op eq "additem") {
         if (!$exist_itemnumber) {
             my ( $oldbiblionumber, $oldbibnum, $oldbibitemnum ) =
                 AddItemFromMarc( $record, $biblionumber, { skip_record_index => 1 } );
+                add_item_to_volume( $oldbiblionumber, $oldbibitemnum, $volume, $volume_description );
 
             # We count the item only if it was really added
             # That way, all items are added, even if there was some already existing barcodes
@@ -998,6 +1031,7 @@ foreach my $tag ( keys %{$tagslib}){
 
 # what's the next op ? it's what we are not in : an add if we're editing, otherwise, and edit.
 $template->param(
+    volumes      => scalar Koha::Biblio::Volumes->search({ biblionumber => $biblionumber }),
     biblionumber => $biblionumber,
     title        => $oldrecord->{title},
     author       => $oldrecord->{author},
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
index bfecf0016c..94bc96352e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
@@ -18,6 +18,9 @@
 [% INCLUDE 'calendar.inc' %]
 [% INCLUDE 'str/cataloging_additem.inc' %]
 [% Asset.js("js/cataloging_additem.js") | $raw %]
+<script>
+  var has_volumes = [% volumes.count %];
+</script>
 </head>
 
 <body id="cat_additem" class="cat">
@@ -238,6 +241,33 @@
     <input type="hidden" name="indicator" value=" " />
     <input type="hidden" name="itemnumber" value="[% itemnumber | html %]" />
 
+[% IF volumes.count && op != 'saveitem' %]
+    <fieldset class="rows">
+        <legend><i class="fa fa-plus"></i> Add to volume</legend>
+
+        <p>
+            <label for="select_volume">Options: </label>
+            <select name="volume" id="volume-add-or-create-form-select">
+                <optgroup label="Use existing volume">
+                    [% FOREACH v IN volumes %]
+                        <option value="[% v.id | html %]">Use: [% v.description | html %]</option>
+                    [% END %]
+                </optgroup>
+                <optgroup label="Other options">
+                    <option id="volume-add-or-create-form-no-add" value="">Do not add to volume</option>
+                    <option value="create">Create new volume</option>
+                </optgroup>
+            </select>
+        </p>
+
+        <p id="volume-add-or-create-form-description-block">
+            <label for="volume_description" class="required">Name: </label>
+            <input name="volume_description" id="volume-add-or-create-form-description" type="text" size="30" class="required" />
+            <span class="required">Required</span>
+        </p>
+    </fieldset>
+[% END %]
+
 <fieldset class="action">    [% IF op != 'saveitem' %]
     <input type="submit" name="phony_submit" value="phony_submit" id="phony_submit" style="display:none;" onclick="return false;" />
     <!-- Note : We use here a false submit button because we have several submit buttons and we don't want the user to believe they validated the adding of multiple items
diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js
index cb841c3e3c..a8be9bf06d 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js
@@ -69,6 +69,26 @@ $(document).ready(function(){
         multiCopyControl.toggle();
     });
 
+    // Add new item to volume
+    if ( has_volumes ) {
+        $('#volume-add-or-create-form-description-block').hide();
+        $('#volume-add-or-create-form-no-add').attr('selected', 'selected' );
+
+        $('#volume-add-or-create-form-select').on('change', function(){
+            if ( $(this).val() == 'create' ) {
+                $('#volume-add-or-create-form-description')
+                    .addClass('required')
+                    .attr( 'required', 'required' );
+                $('#volume-add-or-create-form-description-block').show();
+            } else {
+                $('#volume-add-or-create-form-description')
+                    .removeClass('required')
+                    .removeAttr('required');
+                $('#volume-add-or-create-form-description-block').hide();
+            }
+        });
+    }
+
 });
 
 function Check(f) {
-- 
2.20.1