Bugzilla – Attachment 124795 Details for
Bug 28228
Warns from plugins when metadata value not defined for key
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28228: Supress plugin related error message
Bug-28228-Supress-plugin-related-error-message.patch (text/plain), 1.28 KB, created by
Joonas Kylmälä
on 2021-09-11 13:26:43 UTC
(
hide
)
Description:
Bug 28228: Supress plugin related error message
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-09-11 13:26:43 UTC
Size:
1.28 KB
patch
obsolete
>From 709b8d616be3e2e36368c3f515c123f6a3a4b1c5 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 30 Jun 2020 12:20:39 -0400 >Subject: [PATCH] Bug 28228: Supress plugin related error message >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. > >Test Plan: >1) Install the Kitchen Sink plugin ( it does not have a max versio defined ) >2) Note the warning in your logs >3) Apply this patch >4) Restart all the things >5) No warning! > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > Koha/Plugins/Base.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Plugins/Base.pm b/Koha/Plugins/Base.pm >index e935e74a18..10c66d7486 100644 >--- a/Koha/Plugins/Base.pm >+++ b/Koha/Plugins/Base.pm >@@ -178,7 +178,7 @@ sub get_metadata { > > #FIXME: Why another encoding issue? For metadata containing non latin characters. > my $metadata = $self->{metadata}; >- $metadata->{$_} && utf8::decode($metadata->{$_}) for keys %$metadata; >+ defined($metadata->{$_}) && utf8::decode($metadata->{$_}) for keys %$metadata; > return $metadata; > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28228
:
120176
|
124789
| 124795