Bugzilla – Attachment 124812 Details for
Bug 28992
Resolve warning from undefined BIG_LOOP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28992: Resolve warning on BIG_LOOP
Bug-28992-Resolve-warning-on-BIGLOOP.patch (text/plain), 1.67 KB, created by
Joonas Kylmälä
on 2021-09-12 12:46:06 UTC
(
hide
)
Description:
Bug 28992: Resolve warning on BIG_LOOP
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-09-12 12:46:06 UTC
Size:
1.67 KB
patch
obsolete
>From 84e1bf026bf80349a7bf185d10c6fcc23c8d3a08 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 10 Sep 2021 07:39:40 +0000 >Subject: [PATCH] Bug 28992: Resolve warning on BIG_LOOP >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Argument "" isn't numeric in numeric gt (>) at >/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ >addbiblio.tt line 896. > >Came across it when testing 28608. Could have been a QA follow-up. > >Test plan: >If you run QA tools on this patch, you should see the warning only >when processing files before patches. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 00c6767d1a..7cc0a94afd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -881,7 +881,7 @@ function PopupMARCFieldDoc(field) { > [% END %] > [% END # /UNLESS circborrowernumber %] > <div class="toolbar-tabs-container"> >- [% IF ( BIG_LOOP.size > 1 ) %] >+ [% IF ( BIG_LOOP && BIG_LOOP.size > 1 ) %] > <ul class="toolbar-tabs"> > [%- FOREACH BIG_LOO IN BIG_LOOP -%] > [% IF loop.first %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28992
:
124726
| 124812