From 1ba7815a8df68a4deb028b8fd214245d4fa99590 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Mon, 20 Sep 2021 10:23:10 +0000
Subject: [PATCH] Bug 29057: Use font awesome icons on request.pl

To test:
1 - Place some holds on a record
2 - View the 'Holds' tab in the staff interface
3 - Note the new icons
4 - Note their hover test
5 - Confirm the buttons still work as expected
---
 .../prog/en/includes/holds_table.inc             | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
index 8dd1fcf60f..afba981ccb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ -16,7 +16,7 @@
         <th>Pickup library</th>
         <th>Details</th>
         [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
-            <th><img src="[% interface | html %]/[% theme | html %]/img/go-bottom.png" alt="Toggle set to lowest priority" /></th>
+            <th><i class="fa fa-arrow-circle-down fa-lg" title="Toggle set to lowest priority"></i></th>
         [% END %]
         <th>&nbsp;</th>
         <th>&nbsp;</th>
@@ -83,16 +83,16 @@
                     [%- SET next_priority  = loop.next.priority -%]
                     <td style="white-space:nowrap;">
                         <a title="Move hold up" href="request.pl?action=move&amp;where=up&amp;first_priority=[% first_priority | html %]&amp;last_priority=[% last_priority | html %]&amp;prev_priority=[% prev_priority | html %]&amp;next_priority=[% next_priority | html %]&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
-                            <img src="[% interface | html %]/[% theme | html %]/img/go-up.png" alt="Go up" />
+                            <i class="fa fa-arrow-up fa-lg"></i>
                         </a>
                         <a title="Move hold to top" href="request.pl?action=move&amp;where=top&amp;first_priority=[% first_priority | html %]&amp;last_priority=[% last_priority | html %]&amp;prev_priority=[% prev_priority | html %]&amp;next_priority=[% next_priority | html %]&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
-                            <img src="[% interface | html %]/[% theme | html %]/img/go-top.png" alt="Go top" />
+                            <i class="fa fa-arrow-circle-up fa-lg"></i>
                         </a>
                         <a title="Move hold to bottom" href="request.pl?action=move&amp;where=bottom&amp;first_priority=[% first_priority | html %]&amp;last_priority=[% last_priority | html %]&amp;prev_priority=[% prev_priority | html %]&amp;next_priority=[% next_priority | html %]&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
-                            <img src="[% interface | html %]/[% theme | html %]/img/go-bottom.png" alt="Go bottom" />
+                            <i class="fa fa-arrow-circle-down fa-lg"></i>
                         </a>
                         <a title="Move hold down" href="request.pl?action=move&amp;where=down&amp;first_priority=[% first_priority | html %]&amp;last_priority=[% last_priority | html %]&amp;prev_priority=[% prev_priority | html %]&amp;next_priority=[% next_priority | html %]&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
-                            <img src="[% interface | html %]/[% theme | html %]/img/go-down.png" alt="Go down" />
+                            <i class="fa fa-arrow-down fa-lg"></i>
                         </a>
                     </td>
         [%- ELSE -%]
@@ -174,9 +174,9 @@
                     <td>
                         <a title="Toggle lowest priority" href="request.pl?action=setLowestPriority&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
                             [%- IF ( hold.lowestPriority ) -%]
-                                <img src="[% interface | html %]/[% theme | html %]/img/go-bottom.png" alt="Unset lowest priority" />
+                                <i class="fa fa-arrow-circle-down fa-lg" title="Unset lowest priority"></i>
                             [%- ELSE -%]
-                                <img src="[% interface | html %]/[% theme | html %]/img/go-down.png" alt="Set to lowest priority" />
+                                <i class="fa fa-arrow-circle-o-down fa-lg" title="Set lowest priority"></i>
                             [%- END -%]
                         </a>
                     </td>
@@ -186,7 +186,7 @@
             [%- END -%]
             <td>
                 <a class="cancel-hold" title="Cancel hold" data-borrowernumber="[% hold.borrowernumber | html %]" data-biblionumber="[% hold.biblionumber | html %]" data-id="[% hold.reserve_id | html %]" href="request.pl?action=cancel&amp;borrowernumber=[% hold.borrowernumber | html %]&amp;biblionumber=[% hold.biblionumber | html %]&amp;reserve_id=[% hold.reserve_id | html %]&amp;date=[% hold.date | html %]">
-                    <img src="[% interface | html %]/[% theme | html %]/img/x.png" alt="Cancel" />
+                    <i class="fa fa-times fa-lg" title="Cancel"></i>
                 </a>
             </td>
             <td>
-- 
2.20.1