From d3bc86132e7c627d4923d492b4762d6a5bf434fe Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 21 Sep 2021 10:59:22 +0200 Subject: [PATCH] Bug 28772: Fix Koha/Object.T Koha::ApiKeys is no longer the simple object we need to test Koha::Object->store, let use Koha::Cash::Register --- t/db_dependent/Koha/Object.t | 51 ++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t index a1e10e846a3..6fd1d0fcdc1 100755 --- a/t/db_dependent/Koha/Object.t +++ b/t/db_dependent/Koha/Object.t @@ -628,24 +628,30 @@ subtest 'store() tests' => sub { plan tests => 16; - # Using Koha::ApiKey to test Koha::Object>-store + # Using Koha::Cash::Register to test Koha::Object>-store # Simple object with foreign keys and unique key $schema->storage->txn_begin; - # Create a patron to make sure its ID doesn't exist on the DB - my $patron = $builder->build_object({ class => 'Koha::Patrons' }); - my $patron_id = $patron->id; - $patron->delete; + # Create a library to make sure its ID doesn't exist on the DB + my $library = $builder->build_object({ class => 'Koha::Libraries' }); + my $branchcode = $library->branchcode; + $library->delete; - my $api_key = Koha::ApiKey->new({ patron_id => $patron_id, secret => 'a secret', description => 'a description' }); + my $cash_register = Koha::Cash::Register->new( + { + branch => $library->branchcode, + name => 'a cash register', + description => 'a description', + } + ); my $dbh = $schema->storage->dbh; { local *STDERR; open STDERR, '>', '/dev/null'; throws_ok - { $api_key->store } + { $cash_register->store } 'Koha::Exceptions::Object::FKConstraint', 'Exception is thrown correctly'; is( @@ -655,21 +661,22 @@ subtest 'store() tests' => sub { ); is( $@->broken_fk, - 'patron_id', + 'branch', 'Exception field is correct' ); - $patron = $builder->build_object({ class => 'Koha::Patrons' }); - $api_key = $builder->build_object({ class => 'Koha::ApiKeys' }); + $cash_register = $builder->build_object({ class => 'Koha::Cash::Registers' }); - my $new_api_key = Koha::ApiKey->new({ - patron_id => $patron_id, - secret => $api_key->secret, - description => 'a description', - }); + my $new_cash_register = Koha::Cash::Register->new( + { + branch => $cash_register->branch, + name => $cash_register->name, + description => 'a description', + } + ); throws_ok - { $new_api_key->store } + { $new_cash_register->store } 'Koha::Exceptions::Object::DuplicateID', 'Exception is thrown correctly'; @@ -681,18 +688,18 @@ subtest 'store() tests' => sub { like( $@->duplicate_id, - qr/(api_keys\.)?secret/, + qr/(cash_register\.)?name/, 'Exception field is correct (note that MySQL 8 is displaying the tablename)' ); close STDERR; } # Successful test - $api_key->set({ secret => 'Manuel' }); - my $ret = $api_key->store; - is( ref($ret), 'Koha::ApiKey', 'store() returns the object on success' ); + $cash_register->set({ name => 'Manuel' }); + my $ret = $cash_register->store; + is( ref($ret), 'Koha::Cash::Register', 'store() returns the object on success' ); - my $library = $builder->build_object( { class => 'Koha::Libraries' } ); + $library = $builder->build_object( { class => 'Koha::Libraries' } ); my $patron_category = $builder->build_object( { class => 'Koha::Patron::Categories', @@ -700,7 +707,7 @@ subtest 'store() tests' => sub { } ); - $patron = eval { + my $patron = eval { Koha::Patron->new( { categorycode => $patron_category->categorycode, -- 2.25.1