Bugzilla – Attachment 125109 Details for
Bug 24674
Uncertain years for publicationyear/copyrightdate -- corrected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24674: Adjust tests and add new ones to cover changes
Bug-24674-Adjust-tests-and-add-new-ones-to-cover-c.patch (text/plain), 2.10 KB, created by
Marcel de Rooy
on 2021-09-21 14:41:52 UTC
(
hide
)
Description:
Bug 24674: Adjust tests and add new ones to cover changes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-09-21 14:41:52 UTC
Size:
2.10 KB
patch
obsolete
>From fc8a266bf2c1706c4b27a83250ac82d1259dc4fe Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Feb 2020 14:49:46 +0100 >Subject: [PATCH] Bug 24674: Adjust tests and add new ones to cover changes >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Rebased 21-09-21. >--- > t/db_dependent/Biblio/TransformMarcToKoha.t | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Biblio/TransformMarcToKoha.t b/t/db_dependent/Biblio/TransformMarcToKoha.t >index 5062ed7c48..942c8a14d3 100755 >--- a/t/db_dependent/Biblio/TransformMarcToKoha.t >+++ b/t/db_dependent/Biblio/TransformMarcToKoha.t >@@ -94,7 +94,7 @@ subtest 'Multiple mappings for one kohafield' => sub { > }; > > subtest 'Testing _adjust_pubyear' => sub { >- plan tests => 12; >+ plan tests => 17; > > is( C4::Biblio::_adjust_pubyear('2004 c2000 2007'), 2000, 'First cYEAR' ); > is( C4::Biblio::_adjust_pubyear('2004 2000 2007'), 2004, 'First year' ); >@@ -104,7 +104,12 @@ subtest 'Testing _adjust_pubyear' => sub { > is( C4::Biblio::_adjust_pubyear('1...'), 1000, '1... on its own' ); > is( C4::Biblio::_adjust_pubyear('12?? 13xx'), 1200, '12?? first' ); > is( C4::Biblio::_adjust_pubyear('12? 1x'), undef, 'Too short return nothing as data must be int' ); >- is( C4::Biblio::_adjust_pubyear('198-'), undef, 'Missing question mark, nothing is returned as data must be int' ); >+ is( C4::Biblio::_adjust_pubyear('198-'), '1980', '198-' ); >+ is( C4::Biblio::_adjust_pubyear('19--'), '1900', '19--' ); >+ is( C4::Biblio::_adjust_pubyear('19-'), '1900', '19-' ); >+ is( C4::Biblio::_adjust_pubyear('2---'), '2000', '2---' ); >+ is( C4::Biblio::_adjust_pubyear('2--'), '2000', '2--' ); >+ is( C4::Biblio::_adjust_pubyear('2-'), '2000', '2-' ); > is( C4::Biblio::_adjust_pubyear('198-?'), '1980', '198-?' ); > is( C4::Biblio::_adjust_pubyear('1981-'), '1981', 'Date range returns first date' ); > is( C4::Biblio::_adjust_pubyear('broken'), undef, 'Non-matchign data returns nothing as the field must be int' ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24674
:
99088
|
99173
|
99186
|
125108
|
125109
|
125110
|
126810
|
126811
|
126812