From 04da10a0b2295a4daaaf200fba8388f449453040 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 24 Sep 2021 08:28:17 -0300 Subject: [PATCH] Bug 29107: Rename item_type => item_type_id This simple change renames the attribute in the item object API representation. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass 2. Run: $ git grep 'api/v1/items' => SUCCESS: The items routes are not (yet) used in Koha 3. Run: $ cd koha-tmpl $ git grep --name-only '"embed"' => SUCCESS: Only two templates are using embed. 4. Check: - register.tt uses it to embed the manager, good - parcel.tt uses it to embed items. Alert. => SUCCESS: parcel.tt only uses a count on items. No item_type involved. 5. Sign off Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=29105 --- Koha/Item.pm | 2 +- api/v1/swagger/definitions/item.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 60d80a5c3e..c8f0acdfee 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -1151,7 +1151,7 @@ sub to_api_mapping { ccode => 'collection_code', materials => 'materials_notes', uri => 'uri', - itype => 'item_type', + itype => 'item_type_id', more_subfields_xml => 'extended_subfields', enumchron => 'serial_issue_number', copynumber => 'copy_number', diff --git a/api/v1/swagger/definitions/item.json b/api/v1/swagger/definitions/item.json index 14c110714e..72e6b08214 100644 --- a/api/v1/swagger/definitions/item.json +++ b/api/v1/swagger/definitions/item.json @@ -153,7 +153,7 @@ "type": ["string", "null"], "description": "URL for the item" }, - "item_type": { + "item_type_id": { "type": ["string", "null"], "description": "Itemtype defining the type for this item" }, -- 2.33.0