Bugzilla – Attachment 125397 Details for
Bug 29049
Holds page shows too many priority options in pulldown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29049: Remove reference to optionloop
Bug-29049-Remove-reference-to-optionloop.patch (text/plain), 1.44 KB, created by
Jonathan Druart
on 2021-09-28 12:18:11 UTC
(
hide
)
Description:
Bug 29049: Remove reference to optionloop
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-09-28 12:18:11 UTC
Size:
1.44 KB
patch
obsolete
>From e5efeecd3b5093dd68b975fe398a957361b03280 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Sep 2021 14:17:36 +0200 >Subject: [PATCH] Bug 29049: Remove reference to optionloop > >It's no longer used. >--- > reserve/request.pl | 14 -------------- > 1 file changed, 14 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index cde6ac8de83..95259814bfa 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -374,19 +374,6 @@ foreach my $biblionumber (@biblionumbers) { > my $count = Koha::Holds->search( { biblionumber => $biblionumber } )->count(); > my $totalcount = $count; > >- # FIXME think @optionloop, is maybe obsolete, or must be switchable by a systeme preference fixed rank or not >- # make priorities options >- >- my @optionloop; >- for ( 1 .. $count + 1 ) { >- push( >- @optionloop, >- { >- num => $_, >- selected => ( $_ == $count + 1 ), >- } >- ); >- } > # adding a fixed value for priority options > my $fixedRank = $count+1; > >@@ -711,7 +698,6 @@ foreach my $biblionumber (@biblionumbers) { > > # display infos > $template->param( >- optionloop => \@optionloop, > bibitemloop => \@bibitemloop, > itemdata_enumchron => $itemdata_enumchron, > itemdata_ccode => $itemdata_ccode, >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29049
:
124992
|
125013
|
125067
|
125068
|
125306
|
125307
|
125308
|
125309
|
125310
| 125397