Bugzilla – Attachment 125751 Details for
Bug 29112
Module navigation sidebars in staff now show bullet points
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29112: Module navigation sidebars in staff now show bullet points
Bug-29112-Module-navigation-sidebars-in-staff-now-.patch (text/plain), 3.24 KB, created by
David Nind
on 2021-10-05 20:54:28 UTC
(
hide
)
Description:
Bug 29112: Module navigation sidebars in staff now show bullet points
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-10-05 20:54:28 UTC
Size:
3.24 KB
patch
obsolete
>From 9f5fea2c51f885cc2568d356ca55f187d6a94096 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 5 Oct 2021 16:22:20 +0000 >Subject: [PATCH] Bug 29112: Module navigation sidebars in staff now show > bullet points > >Bug 27873 removed an image file which was still being referenced in the >staff interface CSS, intended to replace the default bullet point in >sidebar menus like Administration and Tools pages have. > >This patch creates a new variable in the SCSS "mixins" file so that the >SVG image file created by Bug 27873 can be reused, and corrects the CSS >for the affected menus. > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > >- Go to Tools -> Patron lists > - The sidebar menu should be styled with little arrows instead of > the default HTML bullets. >- Check the same on an Administration page, e.g. Administration -> > Libraries. >- Check that there hasn't been a regression on the checkout and patron > detail views: > - Check out to a patron who has one or more messages on their account, > e.g. overdues, return claims, holds waiting, notes, messages, etc. > - The display of these list items should be the same: An arrow bullet > point instead of the default. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss | 4 +++- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 4 ++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >index abf0c27b00..6929040b95 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >@@ -5,6 +5,8 @@ $table-border-color: #BCBCBC; > $table-header-background: #E8E8E8; > $table-odd-row: #F9F9F9; > >+$nav-menu-bullet: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='5' height='5' viewBox='0 0 25 25'%3E%3Cpath fill='%23999' d='M9.66.95h4.56l9.21 11.85-9.21 10.53H9.66l5.08-10.53z'/%3E%3C/svg%3E"); >+ > @mixin default-button { > background-image: linear-gradient(to bottom, #FFF 0, #E0E0E0 100%); > border-color: #ADADAD #ADADAD #949494; >@@ -29,4 +31,4 @@ $table-odd-row: #F9F9F9; > background: #EEE none; > border: 1px solid #C0C0C0; > color: #999; >-} >\ No newline at end of file >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 5110580427..91ddc0a966 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -494,7 +494,7 @@ label, > #navmenulist { > li { > border-bottom: 1px solid #EEE; >- list-style-image: url("../img/arrow-bullet.gif"); >+ list-style: $nav-menu-bullet; > padding: .2em 0; > > a { >@@ -1758,7 +1758,7 @@ i { > > .circmessage { > li { >- list-style: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='5' height='5' viewBox='0 0 25 25'%3E%3Cpath fill='%23999' d='M9.66.95h4.56l9.21 11.85-9.21 10.53H9.66l5.08-10.53z'/%3E%3C/svg%3E"); >+ list-style: $nav-menu-bullet; > margin-bottom: .4em; > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29112
:
125746
|
125751
|
126013