Bugzilla – Attachment 125855 Details for
Bug 29179
Useless include in moveitem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29179: Remove useless includes in moveitem.pl
Bug-29179-Remove-useless-includes-in-moveitempl.patch (text/plain), 1.60 KB, created by
Marcel de Rooy
on 2021-10-07 06:23:11 UTC
(
hide
)
Description:
Bug 29179: Remove useless includes in moveitem.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-10-07 06:23:11 UTC
Size:
1.60 KB
patch
obsolete
>From c4b38d29da00bcaaf943e1a0c1688cc3c3ebf055 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 5 Oct 2021 13:24:58 -0300 >Subject: [PATCH] Bug 29179: Remove useless includes in moveitem.pl >Content-Type: text/plain; charset=utf-8 > >This patch moves a trivially unneeded set of includes from this file. > >To test: >1. Apply the patch >2. Try attaching an item to another biblio >=> SUCCESS: Things work as expected! >3. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > cataloguing/moveitem.pl | 10 ---------- > 1 file changed, 10 deletions(-) > >diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl >index 704df49556..ec59c258ff 100755 >--- a/cataloguing/moveitem.pl >+++ b/cataloguing/moveitem.pl >@@ -24,15 +24,8 @@ use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); >-use C4::Context; >-use C4::ClassSource; >-use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/; > > use Koha::Biblios; >- >- >-use MARC::File::XML; >- > use Koha::Items; > > my $query = CGI->new; >@@ -52,8 +45,6 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user( > } > ); > >- >- > my $biblio = Koha::Biblios->find( $biblionumber ); > $template->param(biblio => $biblio); > $template->param(biblionumber => $biblionumber); >@@ -103,5 +94,4 @@ else { > if ( !$biblionumber ) { $template->param( missingbiblionumber => 1 ); } > } > >- > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29179
:
125747
|
125750
| 125855