From 53aff86806c08adf3de1b2730aef0cbc1321189c Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 7 Oct 2021 11:38:14 -0300 Subject: [PATCH] Bug 29168: Only show 'Request article' if allowed on the detail view This patch adds a check for the patron being able to place the request, in the case of logged in patron. The anonymous patron will still be displayed the link, and redirected to the login page as required. To test: 1. Set the article request limit to 1 2. Place a request on behalf of a known patron 3. With the patron session, in the OPAC, try to place a new article request from the detail page => SUCCESS: There's no link 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi --- opac/opac-detail.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 44c0dd083d..65972bc0c2 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -794,14 +794,18 @@ if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) { my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour, opac => 1 }); -if( C4::Context->preference('ArticleRequests') ) { - my $patron = $borrowernumber ? Koha::Patrons->find($borrowernumber) : undef; +if ( C4::Context->preference('ArticleRequests') ) { + my $itemtype = Koha::ItemTypes->find($biblio->itemtype); my $artreqpossible = $patron ? $biblio->can_article_request( $patron ) : $itemtype ? $itemtype->may_article_request : q{}; + + $artreqpossible &&= $patron->can_request_article + if $patron; + $template->param( artreqpossible => $artreqpossible ); } -- 2.32.0