Bugzilla – Attachment 125952 Details for
Bug 28470
Typo: Are you sure you with to chart this report?
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28470: Typo: Are you sure you with to chart this report?
Bug-28470-Typo-Are-you-sure-you-with-to-chart-this.patch (text/plain), 1.92 KB, created by
David Nind
on 2021-10-08 10:33:49 UTC
(
hide
)
Description:
Bug 28470: Typo: Are you sure you with to chart this report?
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-10-08 10:33:49 UTC
Size:
1.92 KB
patch
obsolete
>From 0610f2b24cecec5f248f368826f2e61555e1aeb9 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Oct 2021 14:19:56 +0000 >Subject: [PATCH] Bug 28470: Typo: Are you sure you with to chart this report? > >This patch corrects the text of a warning on the report results page, >from this: > >_("Fetching full chart data for reports with many rows can cause >performance issues. Are you sure you with to chart this report?") > >...to this: > >_("Fetching full chart data for reports with many rows can cause >performance issues. Are you sure you want to chart this report?") > >To test, apply the patch and go to Reports -> Use saved. > > - Run a report which, unlimited, will return more than 1000 rows. > - Click the "Fetch all data for chart" button. > - You should be asked for confirmation. Check that the text is correct. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 3b197dd6f8..1a4c2d9a3d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1560,7 +1560,7 @@ > > $("body").on('click',".fetch_chart_data",function(){ > if( [% unlimited_total || 0 | $raw %] > 1000 ){ >- if( confirm( _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ) ){ >+ if( confirm( _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") ) ){ > return true; > } else { > return false; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28470
:
125887
|
125952
|
126022