From 9f058e647bbf3d575c81e98ae84566886b81e8bd Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 22 Jun 2021 15:43:10 +0200
Subject: [PATCH] Bug 3142: Add itype

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 Koha/Items.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Koha/Items.pm b/Koha/Items.pm
index 0ec3133d8a..3f27ecbd4b 100644
--- a/Koha/Items.pm
+++ b/Koha/Items.pm
@@ -23,6 +23,7 @@ use Modern::Perl;
 use Koha::Database;
 
 use Koha::Item;
+use Koha::CirculationRules;
 
 use base qw(Koha::Objects);
 
@@ -49,6 +50,15 @@ Return the items of the set that are holdable
 sub filter_by_for_hold {
     my ($self) = @_;
 
+    my @hold_not_allowed_itypes = Koha::CirculationRules->search(
+        {
+            rule_name    => 'holdallowed',
+            branchcode   => undef,
+            categorycode => undef,
+            rule_value   => 'not_allowed',
+        }
+    )->get_column('itemtype');
+
     return $self->search(
         {
             itemlost   => 0,
@@ -56,6 +66,7 @@ sub filter_by_for_hold {
             notforloan => { '<=' => 0 }
             ,    # items with negative or zero notforloan value are holdable
             ( C4::Context->preference('AllowHoldsOnDamagedItems') ? ( damaged => 0 ) : () ),
+            itype        => { -not_in => \@hold_not_allowed_itypes },
         }
     );
 }
-- 
2.20.1