Bugzilla – Attachment 126179 Details for
Bug 28349
Date sorting incorrect in some tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28349: [DO NOT PUSH] Recreate the problem
Bug-28349-DO-NOT-PUSH-Recreate-the-problem.patch (text/plain), 2.30 KB, created by
Jonathan Druart
on 2021-10-13 12:10:13 UTC
(
hide
)
Description:
Bug 28349: [DO NOT PUSH] Recreate the problem
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-10-13 12:10:13 UTC
Size:
2.30 KB
patch
obsolete
>From 89c182248f386ea41fb96113ce7f95e743af4b69 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 Oct 2021 14:01:18 +0200 >Subject: [PATCH] Bug 28349: [DO NOT PUSH] Recreate the problem > >You can apply this patch to recreate the problem. >NoSort is removed from the default DT settings but we are passing it >from the KohaTable constructor. We are then expecting the first column >(the checkbox) to not be orderable. >Without the fix, the parameter is not taken into account (ie. not >correctly merged into the DT default parameters). >--- > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 1 - > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 +++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index 0fd092013e2..781363002a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -133,7 +133,6 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > { "targets": [ "title-string" ], "type": "title-string" }, > { "targets": [ "string-sort" ], "type": "string" }, > { "targets": [ "anti-the" ], "type": "anti-the" }, >- { "targets": [ "NoSort" ], "orderable": false, "searchable": false }, > ]; > if ( new_parameters["aoColumnDefs"] === undefined ) { > new_parameters["aoColumnDefs"] = default_column_defs; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 7c2b961d6ca..1f7d0c01a49 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1348,6 +1348,9 @@ Note that permanent location is a code, and location may be an authval. > 'bPaginate': false, > 'bAutoWidth': false, > "aaSorting": [[ 4, "desc" ]], >+ "aoColumnDefs": [ >+ { "targets": [ "NoSort" ], "orderable": false, "searchable": false }, >+ ] > }, columns_settings); > [% END %] > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28349
:
125870
|
125875
| 126179 |
127028