From c6b88804890548601d54ba5d3c3b47e55ea899c0 Mon Sep 17 00:00:00 2001
From: Mark Tompsett <mtompset@hotmail.com>
Date: Tue, 2 Oct 2012 21:28:29 +0800
Subject: [PATCH] Bug 8861 - Undefined variables in batchMod.pl trigger error
logs
Content-Type: text/plain; charset="utf-8"
Initialized $op, and changed lines like "$op => 1" and
"$error => 1" into separate, conditional template param calls.
---
tools/batchMod.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 5469496..00bf5cb 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -51,6 +51,7 @@ my $template_flag;
if (!defined $op) {
$template_name = "tools/batchMod.tmpl";
$template_flag = { tools => '*' };
+ $op = q{};
} else {
$template_name = ($del) ? "tools/batchMod-del.tmpl" : "tools/batchMod-edit.tmpl";
$template_flag = ($del) ? { tools => 'items_batchdel' } : { tools => 'items_batchmod' };
@@ -432,8 +433,8 @@ foreach my $tag (sort keys %{$tagslib}) {
$template->param(%$items_display_hashref) if $items_display_hashref;
$template->param(
op => $nextop,
- $op => 1,
);
+$template->param( $op => 1 ) if $op;
if ($op eq "action") {
@@ -449,7 +450,7 @@ if ($op eq "action") {
}
foreach my $error (@errors) {
- $template->param($error => 1);
+ $template->param($error => 1) if $error;
}
output_html_with_http_headers $input, $cookie, $template->output;
exit;
--
1.7.9.5