From a5d8de2e1914965b68691dae684ead5b82cb537b Mon Sep 17 00:00:00 2001 From: Andrii Veremeienko Date: Sun, 17 Oct 2021 14:43:34 +0300 Subject: [PATCH] Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 Signed-off-by: David Nind --- reserve/placerequest.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index 5ee8dce2f6..1a4e8d7e96 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -53,7 +53,7 @@ my $borrower = Koha::Patrons->find( $borrowernumber ); $borrower = $borrower->unblessed if $borrower; my $biblionumbers = $input->param('biblionumbers'); -$biblionumbers ||= $biblionumber . '/'; +$biblionumbers ||= $biblionumber; my $bad_bibs = $input->param('bad_bibs'); my $holds_to_place_count = $input->param('holds_to_place_count') || 1; @@ -165,9 +165,9 @@ if ( $type eq 'str8' && $borrower ) { } if ($bad_bibs) { - $biblionumbers .= $bad_bibs; + push @biblionumbers, $bad_bibs; } - print $input->redirect("request.pl?biblionumbers=$biblionumbers"); + print $input->redirect("request.pl?biblionumbers=" . join('/', @biblionumbers)); } elsif ( $borrowernumber eq '' ) { print $input->header(); -- 2.20.1