From edaf65236a0dddec7f9182e862029c17e05106e7 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 18 Feb 2020 14:49:46 +0100 Subject: [PATCH] Bug 24674: Adjust tests and add new ones to cover changes Signed-off-by: Marcel de Rooy Rebased 21-09-21. Signed-off-by: Katrin Fischer --- t/db_dependent/Biblio/TransformMarcToKoha.t | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Biblio/TransformMarcToKoha.t b/t/db_dependent/Biblio/TransformMarcToKoha.t index 5062ed7c48..942c8a14d3 100755 --- a/t/db_dependent/Biblio/TransformMarcToKoha.t +++ b/t/db_dependent/Biblio/TransformMarcToKoha.t @@ -94,7 +94,7 @@ subtest 'Multiple mappings for one kohafield' => sub { }; subtest 'Testing _adjust_pubyear' => sub { - plan tests => 12; + plan tests => 17; is( C4::Biblio::_adjust_pubyear('2004 c2000 2007'), 2000, 'First cYEAR' ); is( C4::Biblio::_adjust_pubyear('2004 2000 2007'), 2004, 'First year' ); @@ -104,7 +104,12 @@ subtest 'Testing _adjust_pubyear' => sub { is( C4::Biblio::_adjust_pubyear('1...'), 1000, '1... on its own' ); is( C4::Biblio::_adjust_pubyear('12?? 13xx'), 1200, '12?? first' ); is( C4::Biblio::_adjust_pubyear('12? 1x'), undef, 'Too short return nothing as data must be int' ); - is( C4::Biblio::_adjust_pubyear('198-'), undef, 'Missing question mark, nothing is returned as data must be int' ); + is( C4::Biblio::_adjust_pubyear('198-'), '1980', '198-' ); + is( C4::Biblio::_adjust_pubyear('19--'), '1900', '19--' ); + is( C4::Biblio::_adjust_pubyear('19-'), '1900', '19-' ); + is( C4::Biblio::_adjust_pubyear('2---'), '2000', '2---' ); + is( C4::Biblio::_adjust_pubyear('2--'), '2000', '2--' ); + is( C4::Biblio::_adjust_pubyear('2-'), '2000', '2-' ); is( C4::Biblio::_adjust_pubyear('198-?'), '1980', '198-?' ); is( C4::Biblio::_adjust_pubyear('1981-'), '1981', 'Date range returns first date' ); is( C4::Biblio::_adjust_pubyear('broken'), undef, 'Non-matchign data returns nothing as the field must be int' ); -- 2.11.0