Bugzilla – Attachment 126913 Details for
Bug 11175
Show the parent record's component parts in the detailed views
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11175: Add tests
Bug-11175-Add-tests.patch (text/plain), 3.28 KB, created by
Jonathan Druart
on 2021-10-26 13:18:23 UTC
(
hide
)
Description:
Bug 11175: Add tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-10-26 13:18:23 UTC
Size:
3.28 KB
patch
obsolete
>From 9079df84bfd86e5d54603b339e903e21d93622b5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 26 Oct 2021 15:16:54 +0200 >Subject: [PATCH] Bug 11175: Add tests > >Add coverage for the message set by get_marc_components when the search >fails. >Also cleans a bit the weird return comparisons. >--- > Koha/Biblio.pm | 2 +- > t/db_dependent/Koha/Biblio.t | 32 ++++++++++++++++++++++++++------ > 2 files changed, 27 insertions(+), 7 deletions(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index 2a1d67a993c..29ba22d5026 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -505,7 +505,7 @@ sub get_marc_components { > if( $error || $@ ) { > $error //= q{}; > $error .= $@ if $@; >- warn "Warning from simple_search_compat: $error"; >+ warn "Warning from simple_search_compat: '$error'"; > $self->add_message( > { > type => 'error', >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 8b8f9635884..218015bec6e 100755 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -18,6 +18,7 @@ > use Modern::Perl; > > use Test::More tests => 18; >+use Test::Warn; > > use C4::Biblio qw( AddBiblio ModBiblio ModBiblioMarc ); > use Koha::Database; >@@ -26,6 +27,7 @@ use Koha::Acquisition::Orders; > use Koha::AuthorisedValueCategories; > use Koha::AuthorisedValues; > use Koha::MarcSubfieldStructures; >+use Koha::Exceptions::Exception; > > use MARC::Field; > use MARC::Record; >@@ -509,7 +511,7 @@ subtest 'suggestions() tests' => sub { > > subtest 'get_marc_components() tests' => sub { > >- plan tests => 3; >+ plan tests => 5; > > $schema->storage->txn_begin; > >@@ -519,12 +521,12 @@ subtest 'get_marc_components() tests' => sub { > my $search_mod = Test::MockModule->new( 'Koha::SearchEngine::Zebra::Search' ); > $search_mod->mock( 'simple_search_compat', \&search_component_record2 ); > >- my @components = $host_biblio->get_marc_components; >- is( ref(\@components), 'ARRAY', 'Return type is correct' ); >+ my $components = $host_biblio->get_marc_components; >+ is( ref($components), 'ARRAY', 'Return type is correct' ); > > is_deeply( >- [@components], >- [[]], >+ $components, >+ [], > '->get_marc_components returns an empty ARRAY' > ); > >@@ -534,11 +536,29 @@ subtest 'get_marc_components() tests' => sub { > > is_deeply( > $host_biblio->get_marc_components, >- [($component_record)], >+ [$component_record], > '->get_marc_components returns the related component part record' > ); > $search_mod->unmock( 'simple_search_compat'); > >+ $search_mod->mock( 'simple_search_compat', >+ sub { Koha::Exceptions::Exception->throw("error searching analytics") } >+ ); >+ warning_like { $components = $host_biblio->get_marc_components } >+ qr{^Warning from simple_search_compat: 'error searching analytics'}; >+ >+ is_deeply( >+ $host_biblio->messages, >+ [ >+ { >+ type => 'error', >+ message => 'component_search', >+ payload => "error searching analytics" >+ } >+ ] >+ ); >+ $search_mod->unmock( 'simple_search_compat'); >+ > $schema->storage->txn_rollback; > }; > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11175
:
22612
|
22649
|
23049
|
24788
|
24789
|
24790
|
24791
|
26402
|
26403
|
26404
|
26405
|
26766
|
26767
|
78022
|
78023
|
78024
|
79687
|
79803
|
79809
|
79810
|
105631
|
105641
|
105703
|
105706
|
105707
|
106692
|
112838
|
112839
|
112840
|
112841
|
112846
|
112847
|
112851
|
112852
|
112853
|
112854
|
112855
|
112856
|
112857
|
113649
|
113650
|
113962
|
113964
|
114326
|
114327
|
114328
|
114329
|
114330
|
114331
|
114332
|
114333
|
114334
|
116819
|
116820
|
116821
|
116822
|
116823
|
116824
|
116825
|
116826
|
116827
|
116828
|
119499
|
119506
|
120206
|
122707
|
122708
|
122709
|
122710
|
122711
|
122712
|
122713
|
122714
|
122715
|
122716
|
122717
|
122718
|
123081
|
123082
|
123083
|
123084
|
123085
|
123086
|
123087
|
123088
|
123089
|
123090
|
123091
|
123092
|
123093
|
123406
|
123410
|
123508
|
123509
|
123510
|
123511
|
123512
|
123513
|
123514
|
123515
|
123516
|
123517
|
123518
|
123519
|
123520
|
123521
|
123522
|
123523
|
123524
|
123541
|
123542
|
123543
|
123544
|
123545
|
123546
|
123547
|
123548
|
123549
|
123550
|
123551
|
123552
|
123553
|
123554
|
123555
|
123556
|
123557
|
123562
|
123564
|
123569
|
123570
|
123571
|
123572
|
123573
|
123574
|
123582
|
123583
|
123608
|
123609
|
123611
|
123612
|
123613
|
123614
|
123617
|
123618
|
123619
|
123620
|
123621
|
123622
|
123623
|
123624
|
123625
|
123626
|
123627
|
123628
|
123629
|
123630
|
123631
|
123632
|
123633
|
123634
|
123635
|
123636
|
123637
|
123638
|
123736
|
123737
|
123738
|
123739
|
123740
|
123741
|
123742
|
123743
|
123744
|
123745
|
123746
|
123747
|
123748
|
123749
|
123750
|
123751
|
123752
|
123753
|
123754
|
123755
|
123756
|
124134
|
124135
|
124136
|
124137
|
124138
|
124139
|
124140
|
124141
|
124142
|
124143
|
124144
|
124145
|
124146
|
124147
|
124148
|
124149
|
124150
|
124151
|
124152
|
124153
|
124154
|
124155
|
124382
|
124383
|
124384
|
124385
|
124386
|
124387
|
124388
|
124389
|
124390
|
124391
|
124392
|
124393
|
124394
|
124395
|
124396
|
124397
|
124398
|
124399
|
124400
|
124401
|
124402
|
124403
|
124404
|
124534
|
124535
|
124536
|
124537
|
124538
|
124539
|
124540
|
124541
|
124542
|
124544
|
124545
|
124546
|
124547
|
124548
|
124549
|
124550
|
124551
|
124552
|
124553
|
124554
|
124555
|
124556
|
124557
|
126057
|
126058
|
126059
|
126060
|
126061
|
126062
|
126063
|
126064
|
126065
|
126066
|
126067
|
126068
|
126069
|
126070
|
126071
|
126072
|
126073
|
126074
|
126075
|
126076
|
126077
|
126078
|
126079
|
126080
|
126081
|
126084
|
126441
|
126442
|
126443
|
126687
|
126688
|
126689
|
126690
|
126692
|
126693
|
126694
|
126695
|
126696
|
126697
|
126698
|
126699
|
126700
|
126701
|
126702
|
126703
|
126704
|
126705
|
126706
|
126707
|
126708
|
126709
|
126710
|
126711
|
126712
|
126713
|
126714
|
126715
|
126716
|
126717
|
126718
|
126719
|
126720
|
126721
|
126722
|
126723
|
126724
|
126725
|
126726
|
126727
|
126728
|
126729
|
126730
|
126731
|
126732
|
126733
|
126734
|
126735
|
126736
|
126737
|
126738
|
126739
|
126740
|
126741
|
126742
|
126743
|
126744
|
126745
|
126816
|
126817
|
126869
|
126870
|
126871
|
126872
|
126873
|
126874
|
126875
|
126876
|
126877
|
126878
|
126879
|
126880
|
126881
|
126882
|
126883
|
126884
|
126885
|
126886
|
126887
|
126888
|
126889
|
126890
|
126891
|
126892
|
126893
|
126894
|
126895
|
126897
|
126898
|
126904
|
126911
|
126912
| 126913